Fix #11175 - i18n:collect-phrases -m can't find many important magento phrases - added parsing of the attr translations via $t('Text')

Author: maksymz

setup/src/Magento/Setup/Module/I18n/Parser/Adapter/Html.php

@@ -30,7 +30,11 @@ class Html extends AbstractAdapter
         "/i18n:\s?'(?<value>[^'\\\\]*(?:\\\\.[^'\\\\]*)*)'/i",
         // <translate args="'System Messages'"/>
         // <span translate="'Examples'"></span>
-        "/translate( args|)=\"'(?<value>[^\"\\\\]*(?:\\\\.[^\"\\\\]*)*)'\"/i"
+        "/translate( args|)=\"'(?<value>[^\"\\\\]*(?:\\\\.[^\"\\\\]*)*)'\"/i",
+        // <a data-bind="attr: { title: $t('This is \' test \' data'), href: '#'} "></a>
+        // <input type="text" data-bind="attr: { placeholder: $t('Placeholder'), title: $t('Title') }" />
+        // Double quotes are not handled correctly in the `attr` binding. Move phrase to the UI component property if needed
+        '/\\$t\(\s*([\'"])(?<value>.*?[^\\\])\1.*?[),]/i'
     ];
 
     /**

setup/src/Magento/Setup/Test/Unit/Module/I18n/Parser/Adapter/HtmlTest.php

@@ -103,6 +103,41 @@ public function testParse()
                 'line' => '',
                 'quote' => '',
             ],
+            [
+                // en_US.csv: "This is ' test ' data for attribute translation with single quotes","This is ' test ' data for attribute translation with single quotes"
+                'phrase' => 'This is \\\' test \\\' data for attribute translation with single quotes',
+                'file' => $this->testFile,
+                'line' => '',
+                'quote' => '',
+            ],
+            [
+                // en_US.csv: "This is test data for attribute translation with a quote after''","This is test data for attribute translation with a quote after''"
+                'phrase' => 'This is test data for attribute translation with a quote after\\\'\\\'',
+                'file' => $this->testFile,
+                'line' => '',
+                'quote' => '',
+            ],
+            [
+                // en_US.csv: "This is test data for attribute translation with a quote after' ' ","This is test data for attribute translation with a quote after' ' "
+                'phrase' => 'This is test data for attribute translation with a quote after\\\' \\\' ',
+                'file' => $this->testFile,
+                'line' => '',
+                'quote' => '',
+            ],
+            [
+                // en_US.csv: "Attribute translation - Placeholder","Attribute translation - Placeholder"
+                'phrase' => 'Attribute translation - Placeholder',
+                'file' => $this->testFile,
+                'line' => '',
+                'quote' => '',
+            ],
+            [
+                // en_US.csv: "Attribute translation - Title","Attribute translation - Title"
+                'phrase' => 'Attribute translation - Title',
+                'file' => $this->testFile,
+                'line' => '',
+                'quote' => '',
+            ]
         ];
 
         $this->model->parse($this->testFile);

setup/src/Magento/Setup/Test/Unit/Module/I18n/Parser/Adapter/_files/email.html

@@ -31,5 +31,9 @@
     <label data-bind="i18n: '\\\\ '"></label>
     <span><translate args="'This is test content in translate tag'" /></span>
     <span translate="'This is test content in translate attribute'"></span>
+    <a data-bind="attr: { title: $t('This is \' test \' data for attribute translation with single quotes'), href: '#'} "></a>
+    <a data-bind="attr: { title: $t('This is test data for attribute translation with a quote after\'\''), href: '#'} "></a>
+    <a data-bind="attr: { title: $t('This is test data for attribute translation with a quote after\' \' '), href: '#'} "></a>
+    <input type="text" data-bind="attr: { placeholder: $t('Attribute translation - Placeholder'), title: $t('Attribute translation - Title') }" />
 </body>
 </html>