Skip to content

MC-5410: Banner & Slide Are Missing <A> Tag For Link Attribute On Storefront #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 9, 2018
Merged

MC-5410: Banner & Slide Are Missing <A> Tag For Link Attribute On Storefront #171

merged 9 commits into from
Nov 9, 2018

Conversation

danmooney2
Copy link
Contributor

@danmooney2 danmooney2 commented Nov 7, 2018 •
edited
Loading

Scope

Bug

  • MC-5410 Banner & Slide Are Missing Tag For Link Attribute On Storefront

Jenkins

https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/8370/
https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/8371/

Checklist

  • PR is green on M2 Quality Portal
  • Jira issues have accurate summary, meaningful description and have links to relevant documentation at the story/task level
  • Semantic Version build failure is approved by architect (if build is red)
  • Pull Request approved by architect
  • Pull Request quality review performed by
  • All unstable functional acceptance tests are isolated (if any)
  • All linked Zephyr tests are approved by PO and have Ready to Use status
  • Travis CI build is green (for mainline CE only)
  • Jenkins Extended FAT build is green
  • Pull Request QA review performed by @dhaecker https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/8370/

danmooney2 and others added 9 commits November 2, 2018 11:06
@danmooney2
MC-5410: Banner & Slide Are Missing <A> Tag For Link Attribute On Sto…
7d9ba9e 
…refront

Convert data-href attribute to href
@danmooney2
MC-5410: Banner & Slide Are Missing <A> Tag For Link Attribute On Sto…
96bb525 
…refront

Convert data-target attribute to target
@bdenham
MC-5410: Banner & Slide Are Missing <A> Tag For Link Attribute On Sto…
1bd1278 
…refront

Updated master-format doc to reflect the reverting
@danmooney2
MC-5410: Banner & Slide Are Missing <A> Tag For Link Attribute On Sto…
8748ffe 
…refront

Remove adding link to wysiwyg in banner/slide tests
@danmooney2
MC-5410: Banner & Slide Are Missing <A> Tag For Link Attribute On Sto…
51003d4 
…refront

Convert data-target attribute to target in element selectors
@danmooney2
Merge remote-tracking branch 'origin/MC-5410' into MC-5410
8ac8883
@danmooney2
MC-5410: Banner & Slide Are Missing <A> Tag For Link Attribute On Sto…
a3f8932 
…refront

Remove wysiwyg anchor assertions
@danmooney2
MC-5410: Banner & Slide Are Missing <A> Tag For Link Attribute On Sto…
68d027f 
…refront

Explicitly use anchor tag in xpath selector for targeting linkUrl/openInNewTab elements
@danmooney2
Merge remote-tracking branch 'remotes/mainline/1.0.0-release' into MC…
de34b1d 
…-5410
@cspruiell cspruiell merged commit 511ec8f into magento:1.0.0-release Nov 9, 2018
@michaelyu0123 michaelyu0123 deleted the MC-5410 branch January 16, 2019 17:00
magento-devops-reposync-svc pushed a commit that referenced this pull request Jun 7, 2022
@avattam06
Merge pull request #171 from magento-arcticfoxes/B2B-2221
db0303f 
B2B-2221: Magento\CatalogGraphQl\Plugin\DesignLoader plugin loads too…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danmooney2 @cspruiell @bdenham