-
Notifications
You must be signed in to change notification settings - Fork 131
executeInSelenium generation fix #2 #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jilu1 @KevinBKozan please consider to review and merge this PR. It is very important to us be able to use double quotes inside executeInSelenium. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running a build to see if changes are not breaking any current tests. Will keep you posted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zakdma Builds looks good with this change.
ACQE-5899 : PHP UNIT 10 Upgrade
executeInSelenium action does not generate proper code because it escape all double quotes in function attribute value
Steps to reproduce
<executeInSelenium function="function ($webdriver) { return "Hello, World!"}" stepKey="testStep"/>
vendor/bin/mftf generate:tests
Expected result
There is generated action
$I->executeInSelenium(function ($webdriver) { return "Hello, World!"});
Double quotes are not escaped.
Actual result
There is generated action
$I->executeInSelenium(function ($webdriver) { return \"Hello, World!\"});
Double quotes are escaped.
Contribution checklist