Skip to content

executeInSelenium generation fix #2 #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 14, 2019
Merged

executeInSelenium generation fix #2 #348

merged 6 commits into from
Oct 14, 2019

Conversation

zakdma
Copy link
Contributor

@zakdma zakdma commented May 6, 2019

executeInSelenium action does not generate proper code because it escape all double quotes in function attribute value

Steps to reproduce

  1. Create test with executeInSelenium action
    <executeInSelenium function="function ($webdriver) { return &quot;Hello, World!&quot;}" stepKey="testStep"/>
  2. Run vendor/bin/mftf generate:tests

Expected result

There is generated action
$I->executeInSelenium(function ($webdriver) { return "Hello, World!"});
Double quotes are not escaped.

Actual result

There is generated action
$I->executeInSelenium(function ($webdriver) { return \"Hello, World!\"});
Double quotes are escaped.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented May 6, 2019

Coverage Status

Coverage decreased (-0.7%) to 52.308% when pulling 43ffdbb on zakdma:executeInSelenium2 into 5a4909c on magento:develop.

@soumyau soumyau self-requested a review October 10, 2019 15:19
@zakdma
Copy link
Contributor Author

zakdma commented Oct 10, 2019

@jilu1 @KevinBKozan please consider to review and merge this PR. It is very important to us be able to use double quotes inside executeInSelenium.

Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running a build to see if changes are not breaking any current tests. Will keep you posted.

Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zakdma Builds looks good with this change.

@soumyau soumyau merged commit 8ac2937 into magento:develop Oct 14, 2019
magento-devops-reposync-svc pushed a commit that referenced this pull request May 17, 2024
ACQE-5899 : PHP UNIT 10 Upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants