Optimize GetStockItemData service to avoid repeating SHOW TABLE queries #2561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishakhsuvarov
added a commit
that referenced
this pull request
Nov 22, 2019
…-service Optimize GetStockItemData service to avoid repeating SHOW TABLE queries
robertorubino
added a commit
to magento-sparta/inventory-deprecated
that referenced
this pull request
May 21, 2020
robertorubino
added a commit
to magento-sparta/inventory-deprecated
that referenced
this pull request
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Service
\Magento\InventoryIndexer\Model\ResourceModel\GetStockItemDatamakes redundantSHOW TABLEqueries in situation where Magento is working in single stock mode. This does not make any sense and may be safely refactored to execute this check only on custom stocks.Fixed Issues (if relevant)
Contribution checklist (*)