MSI: #206 - Added strict type static code test #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maghamed
suggested changes
Nov 18, 2017
There was a problem hiding this comment.
Please also provide a blacklist for files which we should exclude from this validation.
For example, we are using legacy code which relies on Duck Typing, and refactoring to comply with Strict Types would cost us a lot.
So, we would just add this file to the Blacklist (files which we skip)
| @@ -266,4 +271,22 @@ public function testCopyPaste() | |||
| "PHP Copy/Paste Detector has found error(s):" . PHP_EOL . $output | |||
| ); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Please provide a description for this method in Comment block before the method
|
Hey @DwayneH could you please address comments I mentioned above |
|
I'll work on it! 👍 |
|
@maghamed Blacklisting and description are now included |
maghamed
approved these changes
Nov 22, 2017
|
Thanks, @DwayneH for your first #MSI contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added static analysis strict_type test to the LiveCodeTest as discussed in #206.