Skip to content

MSI: Contains ui element for stock editor mask #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 27, 2017

Conversation

steinkopffp
Copy link
Contributor

Description

adds website selection field to add/edit stock mask

Manual testing scenarios

  1. create a additional store
  2. create a new stock and view die option selections and check if die main website and the additional store are there.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages

@@ -33,7 +33,7 @@
</thead>

<tbody>
<tr class="data-row" repeat="foreach: elems, item: '$record'">
<tr class="data-row zlel" repeat="foreach: elems, item: '$record'">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why zlel ?

/**
* Provide option values for UI
*
* @api
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't nee the @api flag there - this flag is only for interfaces or spi

@larsroettig
Copy link
Member

Pls fix also the coding style thank you

job__374_6_-_magento-engcom_msi_-_travis_ci

@naydav naydav merged commit af4a7d3 into develop Oct 27, 2017
@maghamed maghamed deleted the msi-inventory-mapping-ui branch December 11, 2018 18:15
magento-devops-reposync-svc pushed a commit that referenced this pull request Oct 1, 2021
MC-41862: Stock status resets to saleable when the product is saved f…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants