Create customer account functionality #254

Stepa4man · 2018-11-19T08:07:56Z

Description

Added the ability to create customer account through the GraphQL

Fixed Issues

magento/graphql-ce/[My Account] Create customer account #248 Create a customer account

Manual testing scenarios (*)

Run in GraphiQL:
mutation { createCustomer ( input: { firstname: "Test" lastname: "Dev" email: "[email protected]" is_subscribed:true } ) { customer{ id, firstname, lastname, email, is_subscribed } } }

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

…tomer and trying to retrieve data

magento-cicd2 · 2018-11-19T08:07:59Z

All committers have signed the CLA.

Stepa4man · 2018-11-19T08:10:24Z

@naydav, I haven't written tests yet. Will be covered a bit later.

naydav

Need to add a possibility to set customer EAV attributes (include validation rules)
Pay attention EAV attributes have own scope

naydav · 2018-11-22T18:02:37Z

app/code/Magento/CustomerGraphQl/Model/Resolver/CreateCustomer.php

+        $customerDataObject->setWebsiteId($store->getWebsiteId());
+        $customerDataObject->setStoreId($store->getId());
+
+        $password = array_key_exists('password', $args['input']) ? $args['input']['password'] : null;


When do we not need a password?

When we want to have registration and then send email to the customer with a link to set a password.
IN current state it works like that:

naydav · 2018-11-22T18:04:17Z

app/code/Magento/CustomerGraphQl/Model/Resolver/CreateCustomer.php

+        try {
+            $customer = $this->createUserAccount($args);
+            $this->setUpUserContext($context, $customer);
+            if (array_key_exists('is_subscribed', $args['input'])) {


Pls, reuse \Magento\CustomerGraphQl\Model\Customer\ChangeSubscriptionStatus

naydav · 2018-11-22T18:05:07Z

app/code/Magento/CustomerGraphQl/Model/Resolver/CreateCustomer.php

+        array $value = null,
+        array $args = null
+    ) {
+        if (!isset($args['input']) || !is_array($args['input']) || empty($args['input'])) {


Need to have more smarty validation (based on is_required values of Customer EAV attributes)

I got it from the current \Magento\CustomerGraphQl\Model\Resolver\UpdateCustomer implementation. Is it ok for updating but not ok for creation?

Just question to think. We can have attribute requirement changed between account creation and account updating. So it also needs to be validated in customer update.

My implementation checks which fields are required

Magento\CustomerGraphQl\Model\Resolver\UpdateCustomer does not contain any validation related to settings in admin panel (there is only one rule need to provide password if you change email)

naydav · 2018-11-22T18:06:48Z

app/code/Magento/CustomerGraphQl/Model/Resolver/CreateCustomer.php

+            }
+            $data = $this->customerDataProvider->getCustomerById((int)$customer->getId());
+        } catch (LocalizedException $e) {
+            throw new GraphQlInputException(__($e->getMessage()));


We don't need to highlight to client all of possible errors

naydav · 2018-11-22T18:07:31Z

app/code/Magento/CustomerGraphQl/Model/Resolver/CreateCustomer.php

+        return ['customer' => $data];
+    }
+
+    private function createUserAccount($args)


Pls, add dockblcoks and type hinting to all of methods (including return values)

Stepa4man · 2018-12-03T22:36:05Z

@naydav eav attributes are implemented

…ed, gender input type changed

…ndling only validation exceptions

naydav · 2018-12-04T14:25:17Z

app/code/Magento/CustomerGraphQl/Model/Resolver/CreateCustomer.php

+use Magento\Newsletter\Model\SubscriberFactory;
+use Magento\Store\Model\StoreManagerInterface;
+
+class CreateCustomer implements ResolverInterface


Need to split this class (an example is in other resolvers of this module)

naydav · 2018-12-04T14:26:02Z

app/code/Magento/CustomerGraphQl/Model/Resolver/CreateCustomer.php

+use Magento\Newsletter\Model\SubscriberFactory;
+use Magento\Store\Model\StoreManagerInterface;
+
+class CreateCustomer implements ResolverInterface


Need to create dockblock for all of classes

naydav · 2018-12-04T14:26:21Z

app/code/Magento/CustomerGraphQl/Model/Resolver/CreateCustomer.php

+     * @var CustomerDataProvider
+     */
+    private $customerDataProvider;
+    /**


Missed rmpty line

naydav · 2018-12-04T14:26:45Z

app/code/Magento/CustomerGraphQl/Model/Resolver/CreateCustomer.php

+     * @throws LocalizedException
+     * @throws NoSuchEntityException
+     */
+    public function resolve(


We can use inheritdoc

naydav · 2018-12-04T14:31:14Z

app/code/Magento/CustomerGraphQl/Model/Resolver/CreateCustomer.php

+        array $value = null,
+        array $args = null
+    ) {
+        if (!isset($args['input']) || !is_array($args['input']) || empty($args['input'])) {


Magento\CustomerGraphQl\Model\Resolver\UpdateCustomer does not contain any validation related to settings in admin panel (there is only one rule need to provide password if you change email)

misha-kotov · 2018-12-06T17:41:07Z

@Stepa4man @naydav Thanks for the demo today! After going back to check on the use cases, it does not look like a guest shopper can create an account without a password on storefront. The Customer configuration options do now allow this either. The only way to create an account without a password is in Admin, which is a use case we do not support. So the password field should be required when creating an account through GraphQL.

Stepa4man · 2018-12-16T23:35:39Z

@misha-kotov
Misha, I still don't agree with you. You have to take into an account that it's just additional possibility for merchants to implement their own vision.
It's not a security issue.
Restricting this we will just restrict Magento's flexibility, I think.

Let me just give you some use case for example:
After a successful checkout guest customer will see a button to create an account. After hitting this button account will be created and the invitation to set a password will be sent to the customer email. So the customer can set this password at any time when it will be convenient for him... Not only right after order checkout.
Please consider my claim=)

misha-kotov · 2018-12-17T16:19:02Z

After discussing this further, we decided to make the password field not required to allow for alternative account creation flows. So out of the box behavior of the endpoint would be:

if the password is specified, customer account is created right away with the password
if the password is not specified, an email is sent to the customer with the set password link

magento-engcom-team · 2019-01-31T22:26:40Z

@Stepa4man thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

ghost · 2019-02-01T23:38:43Z

Hi @Stepa4man, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Stepa4man added 2 commits November 18, 2018 20:13

248: Create customer account

6d5a80c

248:Bugfix - Solved 'user is not authorised' error after creating cus…

91edcc5

…tomer and trying to retrieve data

Stepa4man requested a review from naydav November 19, 2018 08:07

naydav added the in-progress label Nov 20, 2018

merge 2.3-develop

3563671

naydav suggested changes Nov 22, 2018

View reviewed changes

Stepa4man added 4 commits November 28, 2018 22:17

refactoring + first test

af0b38b

Merge branch '2.3-develop' into 248_Create_customer_account

76f9315

extend CustomerInput schema

bcfae0c

Merge branch '2.3-develop' into 248_Create_customer_account

176bc4a

Stepa4man added 3 commits December 4, 2018 00:52

subscription implementetion way changed, schema required fields remov…

9bf12cc

…ed, gender input type changed

added customer input fields doc block, changed try catch block for ha…

906aeb2

…ndling only validation exceptions

turn InputMismatchException into GraphQlInputException

0136faf

naydav reviewed Dec 4, 2018

View reviewed changes

naydav suggested changes Dec 4, 2018

View reviewed changes

split class, format changes

255b8f2

Merge branch '2.3-develop' into 248_Create_customer_account

f2b43e1

GraphQL-248: Test coverage

7c5bea3

novikor mentioned this pull request Jan 30, 2019

[My Account] Create customer account #248

Closed

magento-engcom-team assigned naydav Jan 31, 2019

magento-engcom-team added the Release Line: 2.3 label Jan 31, 2019

magento-engcom-team merged commit 7c5bea3 into magento:2.3-develop Feb 1, 2019

magento-engcom-team pushed a commit that referenced this pull request Feb 1, 2019

ENGCOM-4077: Create customer account functionality #254

f763dd2

magento-engcom-team added the Award: test coverage label Feb 1, 2019

keharper added the requires-documentation label Feb 7, 2019

keharper mentioned this pull request Feb 8, 2019

GraphQL: Update customer endpoint docs for 2.3.1 magento/devdocs#3338

Closed

12 tasks

keharper added documentation-completed and removed requires-documentation labels Mar 2, 2019

awilcoxa mentioned this pull request Mar 4, 2019

DISCOVERY: PWA 2.0 REST queries to Magento 2.3.1 GraphQL magento/pwa-studio#953

Closed

Create customer account functionality #254

Create customer account functionality #254

Uh oh!

Conversation

Stepa4man commented Nov 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Fixed Issues

Manual testing scenarios (*)

Contribution checklist (*)

Uh oh!

magento-cicd2 commented Nov 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Stepa4man commented Nov 19, 2018

Uh oh!

naydav left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Stepa4man Dec 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Stepa4man commented Dec 3, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

misha-kotov commented Dec 6, 2018

Uh oh!

Stepa4man commented Dec 16, 2018

Uh oh!

misha-kotov commented Dec 17, 2018

Uh oh!

magento-engcom-team commented Jan 31, 2019

Uh oh!

ghost commented Feb 1, 2019

Uh oh!

Uh oh!

Stepa4man commented Nov 19, 2018 •

edited

Loading

magento-cicd2 commented Nov 19, 2018 •

edited

Loading

Stepa4man Dec 3, 2018 •

edited

Loading