Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

Extend test testSetNewShippingAddressWithMissedRequiredParameters #1034

Merged
merged 4 commits into from
Nov 1, 2019
Merged

Extend test testSetNewShippingAddressWithMissedRequiredParameters #1034

merged 4 commits into from
Nov 1, 2019

Conversation

TomashKhamlai
Copy link
Contributor

@TomashKhamlai TomashKhamlai commented Oct 28, 2019

Description (*)

Extend test testSetNewShippingAddressWithMissedRequiredParameters with the negative case when the street was omitted to cover #1033: Notice: Undefined index: street

Fixed Issues (if relevant)

  1. n/a

Manual testing scenarios (*)

  1. n/a

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

…h negative case when street was omitted

Signed-off-by: Tomash Khamlai <[email protected]>
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-6212 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@ghost
Copy link

ghost commented Nov 1, 2019

Hi @TomashKhamlai, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants