Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Documented the config-global.php file purpose #9109

Conversation

bgorski
Copy link
Contributor

@bgorski bgorski commented Aug 25, 2021

Purpose of this pull request

This pull request documents the dev/tests/integration/etc/config-global.php - how to use it and what should it be used for.

Affected DevDocs pages

Links to Magento source code

Copy link
Contributor

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small changed - nice addition

@@ -99,6 +99,39 @@ Leave all the settings that do not start with `db-` and `amqp-` at their default
You can include additional setup options—available to the `setup:install` command—in the test configuration file. A
complete list of options is available [here]({{ page.baseurl }}/install-gde/install/cli/install-cli.html).

If your project requires custom entries in the `core_config_data` table (like introduction of new 3rd party services
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If your project requires custom entries in the `core_config_data` table (like introduction of new 3rd party services
If your project requires custom entries in the `core_config_data` table (like the introduction of new 3rd party services

properly), Magento provides a file template that you can use for this purpose.

Copy `dev/tests/integration/etc/config-global.php.dist` to `dev/tests/integration/etc/config-global.php` (without the
`.dist` suffix) and add your path-value pairs there. Do not remove existing entries from the file as they're required
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`.dist` suffix) and add your path-value pairs there. Do not remove existing entries from the file as they're required
`.dist` suffix) and add your path-value pairs there. Do not remove existing entries from the file as they are required

@bgorski
Copy link
Contributor Author

bgorski commented Aug 25, 2021

@BarnyShergold thanks for the CR! Added a commit with both things changed.

Copy link
Contributor

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dobooth dobooth added the Technical Updates to the code or processes that alter the technical content of the doc label Aug 26, 2021
@dobooth
Copy link
Contributor

dobooth commented Aug 26, 2021

@magento import pr to magento-devdocs/devdocs

@magento-engcom-team
Copy link

@dobooth the pull request successfully imported.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 4422164 into magento:master Aug 27, 2021
@ghost
Copy link

ghost commented Aug 27, 2021

Hi @bgorski, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Partner: MRM Commerce partners-contribution PR created by Magento partner Progress: done Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants