This repository was archived by the owner on Nov 19, 2024. It is now read-only.
2FA Updates (redux) #7392
Merged
2FA Updates (redux) #7392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit eb19ecf.
jeff-matthews
added
2.3.x
Closed
Corrected endpoint variables
|
Updated the endpoint variables in the diagram -- see staging #1934 |
ccondra
reviewed
Jun 12, 2020
ccondra
reviewed
Jun 12, 2020
|
I see what's wrong!!! This PR is pointing to the 2.3 directory rather than 2.4. That explains why the content is wrong. I'll check with Jeff to fix it. |
Misc. edits from Nathan's review.
Transferred Nathan's updates from the 2.3 topic to this one.
Moved headless and API content after the basic config instructions.
Reworked the sentence under "Install authenticator" for clarity.
|
I transferred Nathan's review edits from the 2.4 version of this topic to 2.4. |
|
Thanks @ccondra. @nathanjosiah, if there's nothing else, we'd like to get this merged. I need approvals from both you and @ccondra. |
nathanjosiah
approved these changes
Jun 15, 2020
|
Thanks @nathanjosiah! |
|
running tests |
|
Hi @jeff-matthews, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) reverts changes intended for Magento 2.4.0 from the 2.3.x version of the Two Factor Authentication topic. These changes were originally introduced in #7262.
It also applies the second round of 2.4.0 changes for this topic that are included in #7389, which should be closed.
Affected DevDocs pages
Staging: #1940
whatsnew
Reverted changes to the 2.3.x version of the Two Factor Authentication topic and updated the 2.4.x version with the appropriate changes.