Small changes #4204

dobooth · 2019-04-09T20:44:34Z

This PR merges:

/common/images/fdg/lib-map.png -- 95.24kb -> 76.30kb (19.89%)

…sample code

Add spaces to separate repository and package name.

…llation Version change in installation file

remove 1page layout from the code as per the latest version magento2.3 …

#4187 Resolve this issue. This file is used for Pipeline Deployment.

Update composer.md

Update config-reference-gitignore.md for Pipeline Deployment

Zero downtime clarification

Fix Warning Formatting

[ImgBot] Optimize images

magento-cicd2 · 2019-04-09T20:44:37Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
7 out of 8 committers have signed the CLA.

✅ manthandave
✅ likemusic
✅ dobooth
✅ hiteshvaghasiya83
✅ hguthrie
✅ erikmarr
✅ yogeshsuhagiya
❌ ImgBotApp

erikmarr

Very minor extra spaces in path(s).

erikmarr · 2019-04-09T20:54:15Z

guides/v2.1/install-gde/composer.md

@@ -41,19 +41,19 @@ To get the Magento metapackage:

    **{{site.data.var.ce}}**
    ```bash
-    composer create-project --repository=https://repo.magento.com/magento/project-community-edition:<version-tag> <install-directory-name>
+    composer create-project --repository=https://repo.magento.com/ magento/project-community-edition:<version-tag> <install-directory-name>


Looks like an extra space was added.

That's the fix. I was surprised myself.

erikmarr · 2019-04-09T20:54:22Z

guides/v2.1/install-gde/composer.md

    ```

    **{{site.data.var.ee}}**
    ```bash
-    composer create-project --repository=https://repo.magento.com/magento/project-enterprise-edition:<version-tag> <install-directory-name>
+    composer create-project --repository=https://repo.magento.com/ magento/project-enterprise-edition:<version-tag> <install-directory-name>


Looks like an extra space was added.

erikmarr · 2019-04-09T20:54:29Z

guides/v2.1/install-gde/composer.md

    ```

    When prompted, enter your Magento authentication keys. Your _public key_ is your username; your _private key_ is your password.

    To install {{site.data.var.ce}} version 2.2.2 run in current folder:
    ```bash
-    composer create-project --repository=https://repo.magento.com/magento/project-community-edition:2.2.2 .
+    composer create-project --repository=https://repo.magento.com/ magento/project-community-edition:2.2.2 .


Looks like an extra space was added.

Make code in user readable format

Formatted CLI commands

GraphQL sentence improvement

dobooth · 2019-04-10T14:42:04Z

running tests

ghost · 2019-04-10T15:10:05Z

Hi @dobooth, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

ImgBotApp and others added 25 commits April 4, 2019 19:56

[ImgBot] Optimize images

9f53591

/common/images/fdg/lib-map.png -- 95.24kb -> 76.30kb (19.89%)

remove 1page layoufrom the code as per the latest version magento2.3 …

83f7a26

…sample code

Merge branch 'master' into checkout_customize_code

438132f

Update composer.md

302b2fb

Add spaces to separate repository and package name.

version change in installation file

e1ff035

Merge pull request #4191 from manthandave/inventory-managements-insta…

0797170

…llation Version change in installation file

Merge branch 'master' into checkout_customize_code

7f655bc

Merge branch 'master' into small_changes

956cd69

Merge pull request #4178 from manthandave/checkout_customize_code

13664a8

remove 1page layout from the code as per the latest version magento2.3 …

Update config-reference-gitignore.md

a86e231

#4187 Resolve this issue. This file is used for Pipeline Deployment.

Correct to use zero

376fdfb

Merge branch 'master' into patch-11

f83416e

Merge branch 'master' into small_changes

88cb6f1

Merge pull request #4181 from likemusic/patch-11

0f844ce

Update composer.md

Merge branch 'master' into patch-1

78e0900

Merge branch 'master' into small_changes

24ac2d1

Merge pull request #4193 from hiteshvaghasiya83/patch-1

9c462ae

Update config-reference-gitignore.md for Pipeline Deployment

Merge branch 'master' into hg-fixzero

fc7d6ac

Merge branch 'master' into small_changes

18eebf3

Merge pull request #4195 from magento/hg-fixzero

776df2d

Zero downtime clarification

fixing formatting for warning

9b1029c

adding updates for 2.1 and 2.3

dc42fd6

Merge pull request #4203 from magento/em_magento-fixFormatting

f832759

Fix Warning Formatting

Merge branch 'master' into imgbot

14b0807

Merge pull request #4177 from magento/imgbot

6133809

[ImgBot] Optimize images

dobooth self-assigned this Apr 9, 2019

dobooth requested a review from erikmarr April 9, 2019 20:44

erikmarr reviewed Apr 9, 2019

View reviewed changes

Formatted CLI commands

a92113f

yogeshsuhagiya and others added 10 commits April 10, 2019 11:52

Make code in user readable format

b81229d

Change the Sentence Formation and Grammatical Improvements

1bc8930

Merge branch 'master' into master-yogesh-patch-16

827000f

Merge branch 'master' into small_changes

30f0474

Merge pull request #4207 from yogeshsuhagiya/master-yogesh-patch-16

1ad5777

Make code in user readable format

Merge branch 'master' into master-yogesh-patch-15

50d4f57

Merge pull request #4206 from yogeshsuhagiya/master-yogesh-patch-15

20a1a36

Formatted CLI commands

Small tweak.

bb77e7d

Merge branch 'master' into graphql_improvement

117322e

Merge pull request #4208 from manthandave/graphql_improvement

16e8e9c

GraphQL sentence improvement

erikmarr approved these changes Apr 10, 2019

View reviewed changes

Fixed command markup.

365c67d

dobooth merged commit 08b21bb into master Apr 10, 2019

dobooth deleted the small_changes branch April 10, 2019 15:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Small changes #4204

Small changes #4204

Uh oh!

dobooth commented Apr 9, 2019 •

edited

Loading

Uh oh!

magento-cicd2 commented Apr 9, 2019 •

edited

Loading

Uh oh!

erikmarr left a comment

Uh oh!

erikmarr Apr 9, 2019

Uh oh!

dobooth Apr 10, 2019

Uh oh!

erikmarr Apr 9, 2019

Uh oh!

dobooth Apr 10, 2019

Uh oh!

erikmarr Apr 9, 2019

Uh oh!

dobooth Apr 10, 2019

Uh oh!

dobooth commented Apr 10, 2019

Uh oh!

ghost commented Apr 10, 2019

Uh oh!

Uh oh!

Small changes #4204

Small changes #4204

Uh oh!

Conversation

dobooth commented Apr 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This PR merges:

Uh oh!

magento-cicd2 commented Apr 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erikmarr left a comment

Choose a reason for hiding this comment

Uh oh!

erikmarr Apr 9, 2019

Choose a reason for hiding this comment

Uh oh!

dobooth Apr 10, 2019

Choose a reason for hiding this comment

Uh oh!

erikmarr Apr 9, 2019

Choose a reason for hiding this comment

Uh oh!

dobooth Apr 10, 2019

Choose a reason for hiding this comment

Uh oh!

erikmarr Apr 9, 2019

Choose a reason for hiding this comment

Uh oh!

dobooth Apr 10, 2019

Choose a reason for hiding this comment

Uh oh!

dobooth commented Apr 10, 2019

Uh oh!

ghost commented Apr 10, 2019

Uh oh!

Uh oh!

dobooth commented Apr 9, 2019 •

edited

Loading

magento-cicd2 commented Apr 9, 2019 •

edited

Loading