Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Fixing the documentation on how to correctly copy the fieldsets with custom attributes #3992

Merged
merged 6 commits into from
Apr 8, 2019
Merged

Fixing the documentation on how to correctly copy the fieldsets with custom attributes #3992

merged 6 commits into from
Apr 8, 2019

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented Mar 22, 2019 •
edited
Loading

This PR is a:

  • Content update

Summary

When this pull request is merged, it will improve the documentation on how to copy correctly the fieldset from quote to order.

This PR fixes the #2910 issue.

Additional information

List all affected URLs

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

osrecio
osrecio suggested changes Mar 25, 2019
View reviewed changes
Copy link
Member

@osrecio osrecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eduard13 I think your changes are ok. Can you check it out my comments. If you change it we will process this PR as soon as possible

@osrecio osrecio self-assigned this Mar 25, 2019
osrecio
osrecio approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@osrecio osrecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me this PR is ok.

Thanks @eduard13 for your efforts! Good example to have it.

@dobooth
Copy link
Contributor

dobooth commented Mar 27, 2019

Hi @eduard13
Thanks for the contribution.
We aren't making substantive changes to the v2.0 docs, just typos and tiny required changes.
Please back out the v2.0 file from this PR and then we can get it merged.
Thanks!

@dobooth dobooth added Waiting for Response Waiting for response from internal/external parties 2.1.x 2.2.x 2.3.x Magento 2.3 related changes labels Mar 27, 2019
@eduard13
Copy link
Contributor Author

eduard13 commented Mar 27, 2019 •
edited
Loading

Hi @dobooth, I've reverted those changes and updated the PR's description.
Thank you for the feedback.

@eduard13
Copy link
Contributor Author

Hey @dobooth, any updates on this one?
Unfortunately I'm not able to remove the label.

@dobooth dobooth removed the Waiting for Response Waiting for response from internal/external parties label Apr 8, 2019
@dobooth
Copy link
Contributor

dobooth commented Apr 8, 2019

Sorry about that!

@erikmarr
Copy link
Contributor

erikmarr commented Apr 8, 2019

running tests

@erikmarr
Copy link
Contributor

erikmarr commented Apr 8, 2019

running tests

@erikmarr erikmarr merged commit 198d682 into magento:master Apr 8, 2019
@ghost
Copy link

ghost commented Apr 8, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@erikmarr
Copy link
Contributor

erikmarr commented Apr 8, 2019

Thanks @eduard13!

@lorikrell lorikrell mentioned this pull request May 7, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@osrecio osrecio osrecio approved these changes

Assignees

@osrecio osrecio

Labels
2.1.x 2.2.x 2.3.x Magento 2.3 related changes Partner: Atwix partners-contribution PR created by Magento partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eduard13 @devops-devdocs @dobooth @erikmarr @osrecio @magento-engcom-team