Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Fixed issue in <a> tag #1922

Merged
merged 2 commits into from
May 18, 2018
Merged

Conversation

yogeshsuhagiya
Copy link
Member

This PR is a:

Content fix

Summary

  • Set {{ page.baseurl }} instead of static url http://devdocs.magento.com
  • Removed extra href=" parameter of tag
  • Properly closed double quote of <a> tag

When this pull request is merged, it will...

Additional information

@jeff-matthews jeff-matthews self-assigned this May 18, 2018
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yogeshks, thanks for contributing to devdocs!

In this scenario, we actually want to use the static/absolute path to the file because we want to target a specific version. Using the variable implies that this applies to all versions and that's not the case.

@yogeshsuhagiya
Copy link
Member Author

@jeff-matthews Hello,

Okay, we can use static url for that not an issue, but can you please take a look into below screenshot:
screenshot-devdocs-2018 05 18-18-54-13
I've also fixed issue of <a> tag in this commit.

@jeff-matthews jeff-matthews reopened this May 18, 2018
@@ -24,8 +24,8 @@ You can upgrade Magento from the command line if you installed the software usin
</div>

<div class="bs-callout bs-callout-warning">
<ul><li>If you're upgrading to version 2.1, see <a href="http://devdocs.magento.com/guides/v2.1/release-notes/tech_bull_21-upgrade.html">Upgrade to Magento version 2.1 (June 22, 2016)</a>.</li>
<li>If you're upgrading from {{site.data.var.ce}} or {{site.data.var.ee}} 2.0.0 or 2.0.1, you must first perform the tasks discussed in the <a href="href="http://devdocs.magento.com/guides/v2.0/release-notes/tech_bull_201-upgrade.html">Technical Bulletin (1/28/16)</a>.</li></ul>
<ul><li>If you're upgrading to version 2.1, see <a href="{{ page.baseurl }}/release-notes/tech_bull_21-upgrade.html">Upgrade to Magento version 2.1 (June 22, 2016)</a>.</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use the absolute path instead of the variable in this scenario.

<ul><li>If you're upgrading to version 2.1, see <a href="http://devdocs.magento.com/guides/v2.1/release-notes/tech_bull_21-upgrade.html">Upgrade to Magento version 2.1 (June 22, 2016)</a>.</li>
<li>If you're upgrading from {{site.data.var.ce}} or {{site.data.var.ee}} 2.0.0 or 2.0.1, you must first perform the tasks discussed in the <a href="href="http://devdocs.magento.com/guides/v2.0/release-notes/tech_bull_201-upgrade.html">Technical Bulletin (1/28/16)</a>.</li></ul>
<ul><li>If you're upgrading to version 2.1, see <a href="{{ page.baseurl }}/release-notes/tech_bull_21-upgrade.html">Upgrade to Magento version 2.1 (June 22, 2016)</a>.</li>
<li>If you're upgrading from {{site.data.var.ce}} or {{site.data.var.ee}} 2.0.0 or 2.0.1, you must first perform the tasks discussed in the <a href="{{ page.baseurl }}/release-notes/tech_bull_201-upgrade.html">Technical Bulletin (1/28/16)</a>.</li></ul>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use the absolute path instead of the variable in this scenario.

@@ -85,7 +85,7 @@ To prevent access to your store while it's being upgraded, put your store in mai
composer update

<div class="bs-callout bs-callout-info" id="info">
<p>If an error displays about a missing <code>.gitignore</code> files, see the <a href="http://devdocs.magento.com/guides/v2.0/release-notes/tech_bull_201-upgrade.html#resolution2>Technical Bulletin (1/28/16)</a>.</p>
<p>If an error displays about a missing <code>.gitignore</code> files, see the <a href="{{ page.baseurl }}/release-notes/tech_bull_201-upgrade.html#resolution2">Technical Bulletin (1/28/16)</a>.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use the absolute path instead of the variable in this scenario.

@jeff-matthews
Copy link
Contributor

Sorry @yogeshks! I missed that part. Please revert to the absolute path and I'll merge this fix.

@jeff-matthews jeff-matthews added the Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies label May 18, 2018
@yogeshsuhagiya
Copy link
Member Author

Hi @jeff-matthews ,
Thanks to reopen my pull request, I'll set the absolute path.

@yogeshsuhagiya
Copy link
Member Author

Hello @jeff-matthews
I've reset absolute paths, please take a look.

Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yogeshks!

@jeff-matthews jeff-matthews merged commit 714bc38 into magento:develop May 18, 2018
camdixon pushed a commit to camdixon/devdocs that referenced this pull request May 22, 2018
Add the ability to switch to default mode
@ccondra ccondra mentioned this pull request Jun 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants