-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fixed issue in <a> tag #1922
Fixed issue in <a> tag #1922
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yogeshks, thanks for contributing to devdocs!
In this scenario, we actually want to use the static/absolute path to the file because we want to target a specific version. Using the variable implies that this applies to all versions and that's not the case.
@jeff-matthews Hello, Okay, we can use static url for that not an issue, but can you please take a look into below screenshot: |
@@ -24,8 +24,8 @@ You can upgrade Magento from the command line if you installed the software usin | |||
</div> | |||
|
|||
<div class="bs-callout bs-callout-warning"> | |||
<ul><li>If you're upgrading to version 2.1, see <a href="http://devdocs.magento.com/guides/v2.1/release-notes/tech_bull_21-upgrade.html">Upgrade to Magento version 2.1 (June 22, 2016)</a>.</li> | |||
<li>If you're upgrading from {{site.data.var.ce}} or {{site.data.var.ee}} 2.0.0 or 2.0.1, you must first perform the tasks discussed in the <a href="href="http://devdocs.magento.com/guides/v2.0/release-notes/tech_bull_201-upgrade.html">Technical Bulletin (1/28/16)</a>.</li></ul> | |||
<ul><li>If you're upgrading to version 2.1, see <a href="{{ page.baseurl }}/release-notes/tech_bull_21-upgrade.html">Upgrade to Magento version 2.1 (June 22, 2016)</a>.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to use the absolute path instead of the variable in this scenario.
<ul><li>If you're upgrading to version 2.1, see <a href="http://devdocs.magento.com/guides/v2.1/release-notes/tech_bull_21-upgrade.html">Upgrade to Magento version 2.1 (June 22, 2016)</a>.</li> | ||
<li>If you're upgrading from {{site.data.var.ce}} or {{site.data.var.ee}} 2.0.0 or 2.0.1, you must first perform the tasks discussed in the <a href="href="http://devdocs.magento.com/guides/v2.0/release-notes/tech_bull_201-upgrade.html">Technical Bulletin (1/28/16)</a>.</li></ul> | ||
<ul><li>If you're upgrading to version 2.1, see <a href="{{ page.baseurl }}/release-notes/tech_bull_21-upgrade.html">Upgrade to Magento version 2.1 (June 22, 2016)</a>.</li> | ||
<li>If you're upgrading from {{site.data.var.ce}} or {{site.data.var.ee}} 2.0.0 or 2.0.1, you must first perform the tasks discussed in the <a href="{{ page.baseurl }}/release-notes/tech_bull_201-upgrade.html">Technical Bulletin (1/28/16)</a>.</li></ul> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to use the absolute path instead of the variable in this scenario.
@@ -85,7 +85,7 @@ To prevent access to your store while it's being upgraded, put your store in mai | |||
composer update | |||
|
|||
<div class="bs-callout bs-callout-info" id="info"> | |||
<p>If an error displays about a missing <code>.gitignore</code> files, see the <a href="http://devdocs.magento.com/guides/v2.0/release-notes/tech_bull_201-upgrade.html#resolution2>Technical Bulletin (1/28/16)</a>.</p> | |||
<p>If an error displays about a missing <code>.gitignore</code> files, see the <a href="{{ page.baseurl }}/release-notes/tech_bull_201-upgrade.html#resolution2">Technical Bulletin (1/28/16)</a>.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to use the absolute path instead of the variable in this scenario.
Sorry @yogeshks! I missed that part. Please revert to the absolute path and I'll merge this fix. |
Hi @jeff-matthews , |
Hello @jeff-matthews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yogeshks!
Add the ability to switch to default mode
This PR is a:
Content fix
Summary
{{ page.baseurl }}
instead of static urlhttp://devdocs.magento.com
href="
parameter of tag<a>
tagWhen this pull request is merged, it will...
Additional information