Skip to content

currency symbol graphql coverage #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions design-documents/graph-ql/coverage/store-currency-symbol.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
# Coverage for currency symbol

Magento allows to use custom currency symbol.The current graphql implementation does not fully support custom currency symbol feature. The currency query only returns base currency symbol and current store default currency symbol.
`available_currency_codes` should be deprecated and instead `available_currency` field should be added, or both should be kept

## Schema
```graphql
type CurrencyObject {
currency_code: String
currency_symbol: String
}

type CurrencySettings {
base_currency_code: String
base_currency_symbol: String
default_display_currency_code: String
default_display_currency_symbol: String
exchange_rates: [ExchangeRate]
available_currency: [CurrencyObject!]!
}

type Currency @deprecated {
available_currency_codes: [String]
base_currency_code: String
base_currency_symbol: String
default_display_currency_code: String
default_display_currency_symbol: String
exchange_rates: [ExchangeRate]
}

type Query {
currency: Currency @deprecated(description: "use `currency_settings` instead")
currency_settings: CurrencySettings
}
```

All the currency symbol fields should be moved to CurrencySymbolGraphQl module and schema stitched to currency type.