daemon/notify: add support for abstract unix sockets #122
Conversation
|
Thanks for the PR! Could you maybe add some context on how you ended up needing this fix? I know that If you are hitting this bug in some real world scenario, then we can probably assemble a quicker fix using |
|
Setting it up with unix socket abstract namespace was found in the first release of CentOS 7 7.1.1503 (1505_01) when I was doing compatibility testing for our software. I belive it can reproduced by this vagrant box https://cloud.centos.org/centos/7/vagrant/x86_64/images/CentOS-7-Vagrant-1505-x86_64-01.LibVirt.box. |
honsunrise
force-pushed
the
feat/abstract-namespace-support
branch
from
1e0fd93 to
f85e172
Compare
lucab
force-pushed
the
feat/abstract-namespace-support
branch
from
f85e172 to
3bc3f76
Compare
|
Hey @honsunrise, I've pushed a commit on top of your branch to implement the same logic (notify through an abstract Unix socket) without the need of an unstable stdlib feature. It uses existing |
lucab
changed the title
|
@swsnr could you please review this? I'm not sure the original poster is still much active... |
|
@lucab Your commit looks correct to me with respect to the original changes, but I literally have no idea what this pull request itself does, so I can't really review it as a whole. Added my approval, for the record, but take it with a grain of salt 😇 |
|
@lucab That said, I'd prefer to wait for the OP 🙂 As I understand their comments, they're doing some testing for their (proprietary or commercial?) software, so they'd be in the best position to test your changes, and with a commercial background I'd expect them to take responsibility for this change 😇 |
|
@swsnr ack, thanks for the review, I'll wait a bit longer before merging. |
|
It works very well. The test result:
|
This is a draft PR for add support for unix socket abstract namespace.
Wating feature
unix_socket_abstractstable.Tracking issues: rust-lang/rust#85410