This repository was archived by the owner on Dec 22, 2019. It is now read-only.
Implement sort=None behavior #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 1, 2018 17:28
One thing not tested is the behavior when it is impossible to sort (different dtypes being compared). In summary, it will warn, but only when some kind of monoticity condition occurs. The behavior for duplicates is not explicitely tested, but it behaves almost the same as for when there are no duplicates. The new code should fix it better. To consider later, test whole dataframes instead of just indexes... Might catch some unexpected errors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement sort=None behavior and regression tests.
In this it is possible to see how sort=None behaved in the old
DataFrame.append.Regression tests have been tested against origin/MASTER and comprised most of the cases I could think of.