Skip to content

Add vercel quick deployment #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

rubickecho
Copy link

@rubickecho rubickecho commented Sep 27, 2024

Add Vercel Quick Deployment

I really love this project! To make it easier for users to deploy their own JSON editor, I've added a Vercel quick deployment option.

Changes

  1. Added Vercel deployment button and instructions to the README.
  2. Included steps for setting up necessary environment variables after deployment.
  3. Added @types/jest dependency to resolve Vercel deployment issues.

Rationale

Vercel offers a simple and fast way for users to deploy web applications. By adding this quick deployment option, we make it easier for individuals to set up their own instance of JSON For You, potentially increasing adoption and usage of the tool.

The addition of @types/jest was necessary to resolve type-related issues during the Vercel build process.

image

Testing

I've tested the Vercel deployment process and confirmed that it works correctly when following the provided instructions. Test link: https://json4u-psi.vercel.app/editor

Please let me know if you'd like any changes or have any questions about this pull request. Thank you for considering my contribution!

Copy link

netlify bot commented Sep 27, 2024

👷 Deploy request for json4u pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit c6d8960

@loggerhead
Copy link
Owner

@rubickecho 感谢你的贡献,但是我没 get 到为啥用户会需要自行部署 vercel,可以解释一下吗?已经提供了 dockerfile 可以在本地部署,网站也提供了海外和国内两个版本。

@rubickecho
Copy link
Author

@rubickecho 感谢你的贡献,但是我没 get 到为啥用户会需要自行部署 vercel,可以解释一下吗?已经提供了 dockerfile 可以在本地部署,网站也提供了海外和国内两个版本。

是的,这个需求应该偏个人向

  1. 期望以最简单的方式(动动鼠标)部署,dockerfile 还需要一些简单的服务器相关知识
  2. 数据隐私问题,有些工作开发的 json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants