[OpenMP][NFC] Fix warning for OpenMP standalone build #93463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR llvm#75125 introduced upward propagation of some OMPT-related CMake variables. For stand-alone builds this results in a warning that SCOPE_PARENT has no meaning in a top-level directory.
llvmbot
added
openmp:libomp
shiltian
approved these changes
Jun 6, 2024
jhuber6
pushed a commit
that referenced
this pull request
Jun 7, 2024
Without a value set conditional checks like
if(NOT ${OPENMP_STANDALONE_BUILD})
will not be able to evaluate to true.
Fixes issue introduced from PR #93463, which did not allow the OMPT
variable to be propogated up to offload during a runtimes build.
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Jun 8, 2024
revert: 688ffd0b405] Revert "[OpenMP][NFC] Fix warning for OpenMP standalone build (llvm#93463)" breaks aomp openmp Change-Id: I06c26ac45c9e6bd272c2a4539f8d72d835293fca
nekoshirro
pushed a commit
to nekoshirro/Alchemist-LLVM
that referenced
this pull request
Jun 9, 2024
…4801) Without a value set conditional checks like if(NOT ${OPENMP_STANDALONE_BUILD}) will not be able to evaluate to true. Fixes issue introduced from PR llvm#93463, which did not allow the OMPT variable to be propogated up to offload during a runtimes build. Signed-off-by: Hafidz Muzakky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #75125 introduced upward propagation of some OMPT-related CMake variables.
For stand-alone builds this results in a warning that
SCOPE_PARENThas no meaning in a top-level directory.