[Bitcode][Asm] Parse metadata value from operand bundles #87570
Conversation
Created using spr 1.3.6-beta.1
Support parsing operand bundles with metadata value from LLVM IR. This is almost an NFC since there is no existing producers/consumers for metadata operand bundle values, except the following call graph section patches in revision: Producer: https://reviews.llvm.org/D105909?id=358327 Consumer: https://reviews.llvm.org/D105915?id=358335 The test in this revision only ensures that the parser does not complain. The above-mentioned patches implicity test if passed metadata value is correct. Reviewed By: morehouse Differential Revision: https://reviews.llvm.org/D107038?id=362649 Pull Request: llvm#87570
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
llvm/lib/AsmParser/LLParser.cpp
Outdated
| // compiled to bitcode, then disassembled back to LLVM IR. See PR#89649 | ||
| // for the reproducers, and https://bugs.llvm.org/show_bug.cgi?id=51264 |
There was a problem hiding this comment.
| // compiled to bitcode, then disassembled back to LLVM IR. See PR#89649 | |
| // for the reproducers, and https://bugs.llvm.org/show_bug.cgi?id=51264 | |
| // compiled to bitcode, then disassembled back to LLVM IR. | |
| // See [PR#89649](https://github.com/llvm/llvm-project/pull/89649) | |
| // for the reproducers, and https://github.com/llvm/llvm-project/issues/50608 |
I think URLs are better here, since developers can use them directly. The old bugzilla bug also has been migrated to github, so I think its better to use that link.
There was a problem hiding this comment.
I don't think it makes sense to only add support for one half of this... If we add IR parsing support, then bitcode writing should also work.
| @@ -0,0 +1,9 @@ | |||
| ; This test ensures that we parse metadata operand bundle values. | |||
| ; RUN: llvm-as < %s | |||
There was a problem hiding this comment.
No CHECK lines? is this just a test that llvm-as doesn't crash?
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
|
Yeah, I don't think this was rebased in several months, otherwise, I'd expect a conflict between ToT and this patch. If the comment about round tripping the operand bundle through bitcode and back to IR is still relevant, we should probably add a test, and update any bug tracking though. @Prabhuk would you mind following up on that part, since it seems like the functionality you're after is already in tree? |
I've dropped this PR from my patchset. I'll verify if my reproducer (#89649) to test if the round tripping the operand bundle to bitcode and back to IR works correctly on top of main. If required, I'll update the tracking bug, if not I'll close this PR out. |
Support parsing operand bundles with metadata value from LLVM IR.
This is almost an NFC since there is no existing producers/consumers for
metadata operand bundle values, except the following call graph section
patches in revision:
Producer: https://reviews.llvm.org/D105909?id=358327
Consumer: https://reviews.llvm.org/D105915?id=358335
The test in this revision only ensures that the parser does not
complain. The above-mentioned patches implicity test if passed metadata
value is correct.