Skip to content

[SystemZ] Use VT (not ArgVT) for SlotVT in LowerCall(). #82475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

JonPsson1
Copy link
Contributor

When an integer argument is promoted and not split (like i72 -> i128 on a new machine with vector support), the SlotVT should be i128, which is stored in VT - not ArgVT.

Fixes #81417

@JonPsson1 JonPsson1 requested a review from uweigand February 21, 2024 09:20
Copy link
Member

@uweigand uweigand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JonPsson1 JonPsson1 merged commit 9c0e45d into llvm:main Feb 21, 2024
@JonPsson1 JonPsson1 deleted the StackArgVT branch February 21, 2024 15:26
@uweigand uweigand added this to the LLVM 18.X Release milestone Feb 26, 2024
@uweigand
Copy link
Member

/cherry-pick 9c0e45d

llvmbot pushed a commit to llvmbot/llvm-project that referenced this pull request Feb 26, 2024
When an integer argument is promoted and *not* split (like i72 -> i128 on
a new machine with vector support), the SlotVT should be i128, which is
stored in VT - not ArgVT.

Fixes llvm#81417

(cherry picked from commit 9c0e45d)
@llvmbot
Copy link
Member

llvmbot commented Feb 26, 2024

/pull-request #83021

llvmbot pushed a commit to llvmbot/llvm-project that referenced this pull request Feb 26, 2024
When an integer argument is promoted and *not* split (like i72 -> i128 on
a new machine with vector support), the SlotVT should be i128, which is
stored in VT - not ArgVT.

Fixes llvm#81417

(cherry picked from commit 9c0e45d)
@pointhex pointhex mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

[SystemZ] WRONG code with packed struct with bitfield members.
3 participants