Skip to content

Update host CPU detection for Apple M2 and Apple M3 #82100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Feb 17, 2024

CPUFAMILY_ARM_BLIZZARD_AVALANCHE and CPUFAMILY_ARM_EVEREST_SAWTOOTH are taken from <mach/machine.h> in Kernel.framework.

CPUFAMILY_ARM_BLIZZARD_AVALANCHE and CPUFAMILY_ARM_EVEREST_SAWTOOTH are taken from <mach/machine.h> in Kernel.framework.
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@lattner
Copy link
Collaborator

lattner commented Mar 8, 2024

Is there any concern landing this? This would be helpful to get in for us M3 users! :)

@jroelofs
Copy link
Contributor

jroelofs commented Mar 8, 2024

I forgot about this PR, and should have offered to merge it for @madsmtm, if they need me to.

@lattner
Copy link
Collaborator

lattner commented Mar 8, 2024

I'm happy to merge this, just don't want to overstep :) lemme know, it seems "obvious" to me.

@lattner
Copy link
Collaborator

lattner commented Mar 8, 2024

Cool, I'll merge it now, thanks for the feedback Jon

@lattner lattner merged commit 70da915 into llvm:main Mar 8, 2024
Copy link

github-actions bot commented Mar 8, 2024

@madsmtm Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested
by our build bots. If there is a problem with a build, you may recieve a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as
the builds can include changes from many authors. It is not uncommon for your
change to be included in a build that fails due to someone else's changes, or
infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself.
This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

@lattner
Copy link
Collaborator

lattner commented Mar 8, 2024

Also thank you @madsmtm for implementing this!

@madsmtm madsmtm deleted the update-m2-m3-host-detection branch March 9, 2024 12:15
modularbot pushed a commit to modular/modular that referenced this pull request Apr 29, 2025
With llvm/llvm-project#82100 the upstream llvm
can now disambiguate between the different apple architectures.
Anticipate this by improving our handling in the stdlib.

LINALG_ORIG_REV_ID: 304c54aca2812c4be7964f661d0ceed4c162c40b
lriggs1311 pushed a commit to modular/modular that referenced this pull request Apr 29, 2025
With llvm/llvm-project#82100 the upstream llvm
can now disambiguate between the different apple architectures.
Anticipate this by improving our handling in the stdlib.

LINALG_ORIG_REV_ID: 304c54aca2812c4be7964f661d0ceed4c162c40b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants