-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Update host CPU detection for Apple M2 and Apple M3 #82100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CPUFAMILY_ARM_BLIZZARD_AVALANCHE and CPUFAMILY_ARM_EVEREST_SAWTOOTH are taken from <mach/machine.h> in Kernel.framework.
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write If you have received no comments on your PR for a week, you can request a review If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
Is there any concern landing this? This would be helpful to get in for us M3 users! :) |
I forgot about this PR, and should have offered to merge it for @madsmtm, if they need me to. |
I'm happy to merge this, just don't want to overstep :) lemme know, it seems "obvious" to me. |
Cool, I'll merge it now, thanks for the feedback Jon |
@madsmtm Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested Please check whether problems have been caused by your change specifically, as How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
Also thank you @madsmtm for implementing this! |
With llvm/llvm-project#82100 the upstream llvm can now disambiguate between the different apple architectures. Anticipate this by improving our handling in the stdlib. LINALG_ORIG_REV_ID: 304c54aca2812c4be7964f661d0ceed4c162c40b
With llvm/llvm-project#82100 the upstream llvm can now disambiguate between the different apple architectures. Anticipate this by improving our handling in the stdlib. LINALG_ORIG_REV_ID: 304c54aca2812c4be7964f661d0ceed4c162c40b
CPUFAMILY_ARM_BLIZZARD_AVALANCHE
andCPUFAMILY_ARM_EVEREST_SAWTOOTH
are taken from<mach/machine.h>
inKernel.framework
.