Skip to content

[NFC][lldb][lldb-dap] fix C++20 extension warning #140031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025
Merged

Conversation

da-viper
Copy link
Contributor

@da-viper da-viper commented May 15, 2025

warning for designated initializers

from #138116

warning for designated initializers
@da-viper da-viper requested a review from JDevlieghere as a code owner May 15, 2025 09:37
@llvmbot llvmbot added the lldb label May 15, 2025
@llvmbot
Copy link
Member

llvmbot commented May 15, 2025

@llvm/pr-subscribers-lldb

Author: Ebuka Ezike (da-viper)

Changes

warning for designated initializers


Full diff: https://github.com/llvm/llvm-project/pull/140031.diff

1 Files Affected:

  • (modified) lldb/unittests/DAP/ProtocolTypesTest.cpp (+5-5)
diff --git a/lldb/unittests/DAP/ProtocolTypesTest.cpp b/lldb/unittests/DAP/ProtocolTypesTest.cpp
index 0c119bdb544d8..c34d98cf890ef 100644
--- a/lldb/unittests/DAP/ProtocolTypesTest.cpp
+++ b/lldb/unittests/DAP/ProtocolTypesTest.cpp
@@ -305,11 +305,11 @@ TEST(ProtocolTypesTest, Scope) {
   scope.endLine = 10;
   scope.endColumn = 20;
 
-  scope.source =
-      Source{.name = "testName",
-             .path = "/path/to/source",
-             .sourceReference = 12345,
-             .presentationHint = Source::eSourcePresentationHintNormal};
+  // scope.source =
+  scope.source->name = "testName";
+  scope.source->path = "/path/to/source";
+  scope.source->sourceReference = 12345;
+  scope.source->presentationHint = Source::eSourcePresentationHintNormal;
 
   llvm::Expected<Scope> deserialized_scope = roundtrip(scope);
   ASSERT_THAT_EXPECTED(deserialized_scope, llvm::Succeeded());

@da-viper da-viper merged commit e3867cb into llvm:main May 15, 2025
10 checks passed
TIFitis pushed a commit to TIFitis/llvm-project that referenced this pull request May 19, 2025
warning for designated initializers

introduced in commit  4ba8f4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants