Skip to content

[LLDB][NFC]Renaming functions to be consistent with LLDB naming style #128574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

oontvoo
Copy link
Member

@oontvoo oontvoo commented Feb 24, 2025

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Feb 24, 2025

@llvm/pr-subscribers-lldb

Author: Vy Nguyen (oontvoo)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/128574.diff

3 Files Affected:

  • (modified) lldb/include/lldb/Core/Telemetry.h (+2-2)
  • (modified) lldb/source/Core/Telemetry.cpp (+2-2)
  • (modified) lldb/unittests/Core/TelemetryTest.cpp (+3-3)
diff --git a/lldb/include/lldb/Core/Telemetry.h b/lldb/include/lldb/Core/Telemetry.h
index b72556ecaf3c9..3bf38dac04c3d 100644
--- a/lldb/include/lldb/Core/Telemetry.h
+++ b/lldb/include/lldb/Core/Telemetry.h
@@ -64,12 +64,12 @@ class TelemetryManager : public llvm::telemetry::Manager {
   llvm::Error preDispatch(llvm::telemetry::TelemetryInfo *entry) override;
 
   virtual llvm::StringRef GetInstanceName() const = 0;
-  static TelemetryManager *getInstance();
+  static TelemetryManager *GetInstance();
 
 protected:
   TelemetryManager(std::unique_ptr<llvm::telemetry::Config> config);
 
-  static void setInstance(std::unique_ptr<TelemetryManager> manger);
+  static void SetInstance(std::unique_ptr<TelemetryManager> manger);
 
 private:
   std::unique_ptr<llvm::telemetry::Config> m_config;
diff --git a/lldb/source/Core/Telemetry.cpp b/lldb/source/Core/Telemetry.cpp
index 5222f76704f91..a0c9fb83e3a6b 100644
--- a/lldb/source/Core/Telemetry.cpp
+++ b/lldb/source/Core/Telemetry.cpp
@@ -67,9 +67,9 @@ llvm::Error TelemetryManager::preDispatch(TelemetryInfo *entry) {
 }
 
 std::unique_ptr<TelemetryManager> TelemetryManager::g_instance = nullptr;
-TelemetryManager *TelemetryManager::getInstance() { return g_instance.get(); }
+TelemetryManager *TelemetryManager::GetInstance() { return g_instance.get(); }
 
-void TelemetryManager::setInstance(std::unique_ptr<TelemetryManager> manager) {
+void TelemetryManager::SetInstance(std::unique_ptr<TelemetryManager> manager) {
   g_instance = std::move(manager);
 }
 
diff --git a/lldb/unittests/Core/TelemetryTest.cpp b/lldb/unittests/Core/TelemetryTest.cpp
index 0f2eaccb21a2c..3ee6451429619 100644
--- a/lldb/unittests/Core/TelemetryTest.cpp
+++ b/lldb/unittests/Core/TelemetryTest.cpp
@@ -63,10 +63,10 @@ class FakePlugin : public telemetry::TelemetryManager {
   }
 
   static void Initialize() {
-    telemetry::TelemetryManager::setInstance(std::make_unique<FakePlugin>());
+    telemetry::TelemetryManager::SetInstance(std::make_unique<FakePlugin>());
   }
 
-  static void Terminate() { telemetry::TelemetryManager::setInstance(nullptr); }
+  static void Terminate() { telemetry::TelemetryManager::SetInstance(nullptr); }
 };
 
 } // namespace lldb_private
@@ -76,7 +76,7 @@ TEST(TelemetryTest, PluginTest) {
   // For tests, we just call it directly.
   lldb_private::FakePlugin::Initialize();
 
-  auto *ins = lldb_private::telemetry::TelemetryManager::getInstance();
+  auto *ins = lldb_private::telemetry::TelemetryManager::GetInstance();
   ASSERT_NE(ins, nullptr);
 
   std::vector<const ::llvm::telemetry::TelemetryInfo *> expected_entries;

@oontvoo oontvoo merged commit 62ec7b8 into llvm:main Feb 25, 2025
12 checks passed
@oontvoo oontvoo deleted the NFC_rename branch February 25, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants