Skip to content

[libc++] Set feature-test macro __cpp_lib_atomic_float #127559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2025
Merged

[libc++] Set feature-test macro __cpp_lib_atomic_float #127559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c05721
[libc++] Set feature-test macro `__cpp_lib_atomic_float`
frederick-vs-ja Feb 18, 2025
0da0638
Attempt to backport to LLVM 20
frederick-vs-ja Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libcxx/docs/FeatureTestMacroTable.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ Status
---------------------------------------------------------- -----------------
``__cpp_lib_atomic_flag_test`` ``201907L``
---------------------------------------------------------- -----------------
``__cpp_lib_atomic_float`` *unimplemented*
``__cpp_lib_atomic_float`` ``201711L``
---------------------------------------------------------- -----------------
``__cpp_lib_atomic_lock_free_type_aliases`` ``201907L``
---------------------------------------------------------- -----------------
Expand Down
2 changes: 1 addition & 1 deletion libcxx/docs/Status/Cxx20Papers.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"`P0463R1 <https://wg21.link/P0463R1>`__","Endian just Endian","2017-07 (Toronto)","|Complete|","7",""
"`P0674R1 <https://wg21.link/P0674R1>`__","Extending make_shared to Support Arrays","2017-07 (Toronto)","|Complete|","15",""
"","","","","",""
"`P0020R6 <https://wg21.link/P0020R6>`__","Floating Point Atomic","2017-11 (Albuquerque)","|Complete|","18",""
"`P0020R6 <https://wg21.link/P0020R6>`__","Floating Point Atomic","2017-11 (Albuquerque)","|Complete|","18","The feature-test macro was not set until LLVM 20."
"`P0053R7 <https://wg21.link/P0053R7>`__","C++ Synchronized Buffered Ostream","2017-11 (Albuquerque)","|Complete|","18",""
"`P0202R3 <https://wg21.link/P0202R3>`__","Add constexpr modifiers to functions in <algorithm> and <utility> Headers","2017-11 (Albuquerque)","|Complete|","12",""
"`P0415R1 <https://wg21.link/P0415R1>`__","Constexpr for ``std::complex``\ ","2017-11 (Albuquerque)","|Complete|","16",""
Expand Down
2 changes: 1 addition & 1 deletion libcxx/include/version
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ __cpp_lib_void_t 201411L <type_traits>
# define __cpp_lib_array_constexpr 201811L
# define __cpp_lib_assume_aligned 201811L
# define __cpp_lib_atomic_flag_test 201907L
// # define __cpp_lib_atomic_float 201711L
# define __cpp_lib_atomic_float 201711L
# define __cpp_lib_atomic_lock_free_type_aliases 201907L
# define __cpp_lib_atomic_ref 201806L
// # define __cpp_lib_atomic_shared_ptr 201711L
Expand Down
48 changes: 15 additions & 33 deletions ...td/language.support/support.limits/support.limits.general/atomic.version.compile.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,17 +169,11 @@
# error "__cpp_lib_atomic_flag_test should have the value 201907L in c++20"
# endif

# if !defined(_LIBCPP_VERSION)
# ifndef __cpp_lib_atomic_float
# error "__cpp_lib_atomic_float should be defined in c++20"
# endif
# if __cpp_lib_atomic_float != 201711L
# error "__cpp_lib_atomic_float should have the value 201711L in c++20"
# endif
# else // _LIBCPP_VERSION
# ifdef __cpp_lib_atomic_float
# error "__cpp_lib_atomic_float should not be defined because it is unimplemented in libc++!"
# endif
# ifndef __cpp_lib_atomic_float
# error "__cpp_lib_atomic_float should be defined in c++20"
# endif
# if __cpp_lib_atomic_float != 201711L
# error "__cpp_lib_atomic_float should have the value 201711L in c++20"
# endif

# ifndef __cpp_lib_atomic_is_always_lock_free
Expand Down Expand Up @@ -262,17 +256,11 @@
# error "__cpp_lib_atomic_flag_test should have the value 201907L in c++23"
# endif

# if !defined(_LIBCPP_VERSION)
# ifndef __cpp_lib_atomic_float
# error "__cpp_lib_atomic_float should be defined in c++23"
# endif
# if __cpp_lib_atomic_float != 201711L
# error "__cpp_lib_atomic_float should have the value 201711L in c++23"
# endif
# else // _LIBCPP_VERSION
# ifdef __cpp_lib_atomic_float
# error "__cpp_lib_atomic_float should not be defined because it is unimplemented in libc++!"
# endif
# ifndef __cpp_lib_atomic_float
# error "__cpp_lib_atomic_float should be defined in c++23"
# endif
# if __cpp_lib_atomic_float != 201711L
# error "__cpp_lib_atomic_float should have the value 201711L in c++23"
# endif

# ifndef __cpp_lib_atomic_is_always_lock_free
Expand Down Expand Up @@ -355,17 +343,11 @@
# error "__cpp_lib_atomic_flag_test should have the value 201907L in c++26"
# endif

# if !defined(_LIBCPP_VERSION)
# ifndef __cpp_lib_atomic_float
# error "__cpp_lib_atomic_float should be defined in c++26"
# endif
# if __cpp_lib_atomic_float != 201711L
# error "__cpp_lib_atomic_float should have the value 201711L in c++26"
# endif
# else // _LIBCPP_VERSION
# ifdef __cpp_lib_atomic_float
# error "__cpp_lib_atomic_float should not be defined because it is unimplemented in libc++!"
# endif
# ifndef __cpp_lib_atomic_float
# error "__cpp_lib_atomic_float should be defined in c++26"
# endif
# if __cpp_lib_atomic_float != 201711L
# error "__cpp_lib_atomic_float should have the value 201711L in c++26"
# endif

# ifndef __cpp_lib_atomic_is_always_lock_free
Expand Down
48 changes: 15 additions & 33 deletions ...d/language.support/support.limits/support.limits.general/version.version.compile.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3282,17 +3282,11 @@
# error "__cpp_lib_atomic_flag_test should have the value 201907L in c++20"
# endif

# if !defined(_LIBCPP_VERSION)
# ifndef __cpp_lib_atomic_float
# error "__cpp_lib_atomic_float should be defined in c++20"
# endif
# if __cpp_lib_atomic_float != 201711L
# error "__cpp_lib_atomic_float should have the value 201711L in c++20"
# endif
# else // _LIBCPP_VERSION
# ifdef __cpp_lib_atomic_float
# error "__cpp_lib_atomic_float should not be defined because it is unimplemented in libc++!"
# endif
# ifndef __cpp_lib_atomic_float
# error "__cpp_lib_atomic_float should be defined in c++20"
# endif
# if __cpp_lib_atomic_float != 201711L
# error "__cpp_lib_atomic_float should have the value 201711L in c++20"
# endif

# ifndef __cpp_lib_atomic_is_always_lock_free
Expand Down Expand Up @@ -4707,17 +4701,11 @@
# error "__cpp_lib_atomic_flag_test should have the value 201907L in c++23"
# endif

# if !defined(_LIBCPP_VERSION)
# ifndef __cpp_lib_atomic_float
# error "__cpp_lib_atomic_float should be defined in c++23"
# endif
# if __cpp_lib_atomic_float != 201711L
# error "__cpp_lib_atomic_float should have the value 201711L in c++23"
# endif
# else // _LIBCPP_VERSION
# ifdef __cpp_lib_atomic_float
# error "__cpp_lib_atomic_float should not be defined because it is unimplemented in libc++!"
# endif
# ifndef __cpp_lib_atomic_float
# error "__cpp_lib_atomic_float should be defined in c++23"
# endif
# if __cpp_lib_atomic_float != 201711L
# error "__cpp_lib_atomic_float should have the value 201711L in c++23"
# endif

# ifndef __cpp_lib_atomic_is_always_lock_free
Expand Down Expand Up @@ -6369,17 +6357,11 @@
# error "__cpp_lib_atomic_flag_test should have the value 201907L in c++26"
# endif

# if !defined(_LIBCPP_VERSION)
# ifndef __cpp_lib_atomic_float
# error "__cpp_lib_atomic_float should be defined in c++26"
# endif
# if __cpp_lib_atomic_float != 201711L
# error "__cpp_lib_atomic_float should have the value 201711L in c++26"
# endif
# else // _LIBCPP_VERSION
# ifdef __cpp_lib_atomic_float
# error "__cpp_lib_atomic_float should not be defined because it is unimplemented in libc++!"
# endif
# ifndef __cpp_lib_atomic_float
# error "__cpp_lib_atomic_float should be defined in c++26"
# endif
# if __cpp_lib_atomic_float != 201711L
# error "__cpp_lib_atomic_float should have the value 201711L in c++26"
# endif

# ifndef __cpp_lib_atomic_is_always_lock_free
Expand Down
1 change: 0 additions & 1 deletion libcxx/utils/generate_feature_test_macro_components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,6 @@ def add_version_header(tc):
"name": "__cpp_lib_atomic_float",
"values": {"c++20": 201711},
"headers": ["atomic"],
"unimplemented": True,
},
{
"name": "__cpp_lib_atomic_is_always_lock_free",
Expand Down