Skip to content

[mlir] [test] Do not add dependencies on llvm tools in standalone builds #120911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

mgorny
Copy link
Member

@mgorny mgorny commented Dec 22, 2024

Since LLVM tools are installed system-wide, adding dependencies on them is unnecessary. Furthermore, it is problematic for multilib builds, where the tools are only built once, for the native ABI, and therefore are not listed in CMake files for non-native ABIs.

Since LLVM tools are installed system-wide, adding dependencies on them
is unnecessary.  Furthermore, it is problematic for multilib builds,
where the tools are only built once, for the native ABI, and therefore
are not listed in CMake files for non-native ABIs.
@llvmbot llvmbot added the mlir label Dec 22, 2024
@llvmbot
Copy link
Member

llvmbot commented Dec 22, 2024

@llvm/pr-subscribers-mlir

Author: Michał Górny (mgorny)

Changes

Since LLVM tools are installed system-wide, adding dependencies on them is unnecessary. Furthermore, it is problematic for multilib builds, where the tools are only built once, for the native ABI, and therefore are not listed in CMake files for non-native ABIs.


Full diff: https://github.com/llvm/llvm-project/pull/120911.diff

1 Files Affected:

  • (modified) mlir/test/CMakeLists.txt (+3-1)
diff --git a/mlir/test/CMakeLists.txt b/mlir/test/CMakeLists.txt
index f181a91328f3fe..58d16a657297e6 100644
--- a/mlir/test/CMakeLists.txt
+++ b/mlir/test/CMakeLists.txt
@@ -99,7 +99,6 @@ configure_lit_site_cfg(
   )
 
 set(MLIR_TEST_DEPENDS
-  FileCheck count not split-file
   mlir-capi-ir-test
   mlir-capi-irdl-test
   mlir-capi-llvm-test
@@ -121,6 +120,9 @@ set(MLIR_TEST_DEPENDS
   tblgen-lsp-server
   tblgen-to-irdl
   )
+if(NOT MLIR_STANDALONE_BUILD)
+  list(APPEND MLIR_TEST_DEPENDS FileCheck count not split-file)
+endif()
 
 set(MLIR_TEST_DEPENDS ${MLIR_TEST_DEPENDS}
   mlir-capi-pdl-test

@mgorny mgorny merged commit 9e38e87 into llvm:main Dec 25, 2024
10 checks passed
@mgorny mgorny deleted the mlir-standalone-test-deps branch December 25, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants