[clang][NFC] Fix the static assertion in 4797437

[ziqingluo-90]

In the previous commit 4797437, I used llvm::isInt<NumStmtBits>(StmtClass::LAST##Class) to test if StmtClass is strictly bounded by the an unsigned integer of 'NumStmtBits'. That is incorrect as llvm::isInt tests for signed integers. This commit fixes it.

[llvmbot]

@llvm/pr-subscribers-clang

Author: Ziqing Luo (ziqingluo-90)

Changes

In the previous commit 4797437, I used llvm::isInt<NumStmtBits>(StmtClass::LAST##Class) to test if StmtClass is strictly bounded by the an unsigned integer of 'NumStmtBits'. That is incorrect as llvm::isInt tests for signed integers. This commit fixes it.

---

Full diff: https://github.com/llvm/llvm-project/pull/120643.diff

1 Files Affected:

• (modified) clang/include/clang/AST/Stmt.h (+4-4)

diff --git a/clang/include/clang/AST/Stmt.h b/clang/include/clang/AST/Stmt.h
index 07cb63956aed0d..ef6824199b0af0 100644
--- a/clang/include/clang/AST/Stmt.h
+++ b/clang/include/clang/AST/Stmt.h
@@ -114,10 +114,10 @@ class alignas(void *) Stmt {
 #define STMT(CLASS, PARENT)
 #define STMT_RANGE(BASE, FIRST, LAST)
 #define LAST_STMT_RANGE(BASE, FIRST, LAST)                                     \
-  static_assert(                                                               \
-      llvm::isInt<NumStmtBits>(StmtClass::LAST##Class),                        \
-      "The number of 'StmtClass'es is strictly bounded under two to "          \
-      "the power of 'NumStmtBits'");
+  static_assert(0 <= StmtClass::LAST##Class &&                                 \
+                    StmtClass::LAST##Class < (INT64_C(1) << NumStmtBits),      \
+                "The number of 'StmtClass'es is strictly bound by a bitfield " \
+                "of width NumStmtBits");
 #define ABSTRACT_STMT(STMT)
 #include "clang/AST/StmtNodes.inc"
 

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.

[jroelofs]

may as well address @nikic's post-commit suggestion to move this out of the header, and into a source file, while you're here: #120341 (comment)

[ziqingluo-90]

#120341 (comment)

oops, I saw this after I hit the merge button. I will do it in a follow-up commit.