[lldb] Replace Code Owners with Maintainers #111686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To align with the new policy: https://llvm.org/docs/DeveloperPolicy.html#maintainers I've assumed that Jonas will be the "Lead Maintainer" as he was the default Code Owner. I know the past Code Owners weren't "Maintainers" but it's the same energy so I've changed it there too.
|
@llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) ChangesTo align with the new policy: https://llvm.org/docs/DeveloperPolicy.html#maintainers I've assumed that Jonas will be the "Lead Maintainer" as he was the default Code Owner. I know the past Code Owners weren't "Maintainers" but it's the same energy so I've changed it there too. Full diff: https://github.com/llvm/llvm-project/pull/111686.diff 1 Files Affected:
diff --git a/lldb/CodeOwners.rst b/lldb/Maintainers.rst
similarity index 91%
rename from lldb/CodeOwners.rst
rename to lldb/Maintainers.rst
index 3c10c2a28da9e7..e83591d5f162b4 100644
--- a/lldb/CodeOwners.rst
+++ b/lldb/Maintainers.rst
@@ -1,27 +1,31 @@
================
-LLDB Code Owners
+LLDB Maintainers
================
-This file is a list of the `code owners <https://llvm.org/docs/DeveloperPolicy.html#code-owners>`_ for LLDB.
+This file is a list of the `maintainers <https://llvm.org/docs/DeveloperPolicy.html#maintainers>`_ for LLDB.
.. contents::
:depth: 2
:local:
-Current Code Owners
+Current Maintainers
===================
-The following people are the active code owners for the project. Please reach
+The following people are the active maintainers for the project. Please reach
out to them for code reviews, questions about their area of expertise, or other
assistance.
-All parts of LLDB not covered by someone else
-----------------------------------------------
+Lead Maintainer
+---------------
+
+Responsible for project as a whole, and for any areas not covered by a specific
+maintainer.
+
| Jonas Devlieghere
| jonas\@devlieghere.com (email), jdevlieghere (GitHub), jdevlieghere (Discourse), jdevlieghere (Discord)
Components
----------
-These code owners are responsible for particular high-level components within
+These maintainers are responsible for particular high-level components within
LLDB.
ABI
@@ -242,10 +246,10 @@ lldb-dap
| Walter Erquinigo
| a20012251\@gmail.com (email), walter-erquinigo (GitHub), wallace (Discourse), werquinigo (Discord)
-Former Code Owners
+Former Maintainers
==================
-The following people have graciously spent time performing code ownership
-responsibilities but are no longer active in that role. Thank you for all your
+The following people have graciously spent time performing maintainership
+duties but are no longer active in that role. Thank you for all your
help with the success of the project!
| Kamil Rytarowski (kamil\@netbsd.org)
|
|
Folks may want to read the new wording for themselves, but at least by my interpretation there's not much change from what I myself have been doing and what I've seen the folks listed in this file doing. So I don't think you're opting into a whole lot more work. |
DavidSpickett
requested review from
labath,
omjavaid,
walter-erquinigo,
clayborg,
jasonmolenda,
jimingham and
medismailben
|
Added a bunch of you on review not because this is some complex change, but just as a heads up in case you did want to reconsider being listed here or suggest alternatives. |
JDevlieghere
approved these changes
Oct 9, 2024
|
I'll land this on Monday unless anyone objects. After that anyone can make their own changes as usual. |
labath
approved these changes
Oct 10, 2024
DanielCChen
pushed a commit
to DanielCChen/llvm-project
that referenced
this pull request
Oct 16, 2024
To align with the new policy: https://llvm.org/docs/DeveloperPolicy.html#maintainers I've assumed that Jonas will be the "Lead Maintainer" as he was the default Code Owner. I know the past Code Owners weren't "Maintainers" but it's the same energy so I've changed it there too. See also: llvm#107384 / https://discourse.llvm.org/t/rfc-proposing-changes-to-the-community-code-ownership-policy/80714
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To align with the new policy: https://llvm.org/docs/DeveloperPolicy.html#maintainers
I've assumed that Jonas will be the "Lead Maintainer" as he was the default Code Owner.
I know the past Code Owners weren't "Maintainers" but it's the same energy so I've changed it there too.
See also: #107384 / https://discourse.llvm.org/t/rfc-proposing-changes-to-the-community-code-ownership-policy/80714