Skip to content

[NFC][ModuleUtils] Test appendToGlobalCtors/appendToGlobalDtors #101753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vitalybuka
Copy link
Collaborator

No description provided.

Created using spr 1.3.4
@llvmbot
Copy link
Member

llvmbot commented Aug 2, 2024

@llvm/pr-subscribers-llvm-transforms

Author: Vitaly Buka (vitalybuka)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/101753.diff

1 Files Affected:

  • (modified) llvm/unittests/Transforms/Utils/ModuleUtilsTest.cpp (+55)
diff --git a/llvm/unittests/Transforms/Utils/ModuleUtilsTest.cpp b/llvm/unittests/Transforms/Utils/ModuleUtilsTest.cpp
index faca3bc03f120..5e712ca223628 100644
--- a/llvm/unittests/Transforms/Utils/ModuleUtilsTest.cpp
+++ b/llvm/unittests/Transforms/Utils/ModuleUtilsTest.cpp
@@ -9,6 +9,7 @@
 #include "llvm/Transforms/Utils/ModuleUtils.h"
 #include "llvm/ADT/StringRef.h"
 #include "llvm/AsmParser/Parser.h"
+#include "llvm/IR/Constants.h"
 #include "llvm/IR/LLVMContext.h"
 #include "llvm/IR/Module.h"
 #include "llvm/Support/SourceMgr.h"
@@ -67,3 +68,57 @@ TEST(ModuleUtils, AppendToUsedList2) {
   appendToUsed(*M, Globals);
   EXPECT_EQ(1, getListSize(*M, "llvm.used"));
 }
+
+using ParamType = std::pair<StringRef, decltype(&appendToGlobalCtors)>;
+class ModuleUtilsTest : public testing::TestWithParam<ParamType> {};
+
+INSTANTIATE_TEST_SUITE_P(
+    ModuleUtilsTestCtors, ModuleUtilsTest,
+    ::testing::Values(ParamType{"llvm.global_ctors", &appendToGlobalCtors},
+                      ParamType{"llvm.global_dtors", &appendToGlobalDtors}));
+
+TEST_P(ModuleUtilsTest, AppendToMissingArray) {
+  auto [ArrayName, Fn] = GetParam();
+
+  LLVMContext C;
+
+  std::unique_ptr<Module> M = parseIR(C, "");
+
+  EXPECT_EQ(0, getListSize(*M, ArrayName));
+  Function *F = cast<Function>(
+      M->getOrInsertFunction("ctor", Type::getVoidTy(C)).getCallee());
+  Fn(*M, F, 11, F);
+  ASSERT_EQ(1, getListSize(*M, ArrayName));
+
+  ConstantArray *CA = dyn_cast<ConstantArray>(
+      M->getGlobalVariable(ArrayName)->getInitializer());
+  ASSERT_NE(nullptr, CA);
+  ConstantStruct *CS = dyn_cast<ConstantStruct>(CA->getOperand(0));
+  ASSERT_NE(nullptr, CS);
+  ConstantInt * Pri = dyn_cast<ConstantInt>(CS->getOperand(0));
+  ASSERT_NE(nullptr, Pri);
+  EXPECT_EQ(11u, Pri->getLimitedValue());
+  EXPECT_EQ(F, dyn_cast<Function>(CS->getOperand(1)));
+  EXPECT_EQ(F, CS->getOperand(2));
+}
+
+TEST_P(ModuleUtilsTest, AppendToArray) {
+  auto [ArrayName, Fn] = GetParam();
+
+  LLVMContext C;
+
+  std::unique_ptr<Module> M = parseIR(
+      C, (R"(@)" + ArrayName + R"( = appending global [2 x { i32, ptr, ptr }] [
+            { i32, ptr, ptr } { i32 65535, ptr  null, ptr null },
+            { i32, ptr, ptr } { i32 0, ptr  null, ptr null }]
+      )")
+             .str()
+             .c_str());
+
+  EXPECT_EQ(2, getListSize(*M, ArrayName));
+  Fn(*M,
+     cast<Function>(
+         M->getOrInsertFunction("ctor", Type::getVoidTy(C)).getCallee()),
+     11, nullptr);
+  EXPECT_EQ(3, getListSize(*M, ArrayName));
+}

Created using spr 1.3.4
@vitalybuka vitalybuka changed the base branch from users/vitalybuka/spr/main.nfcmoduleutils-test-appendtoglobalctorsappendtoglobaldtors to main August 2, 2024 23:38
Created using spr 1.3.4
@vitalybuka vitalybuka merged commit a0a9bf5 into main Aug 2, 2024
4 of 6 checks passed
@vitalybuka vitalybuka deleted the users/vitalybuka/spr/nfcmoduleutils-test-appendtoglobalctorsappendtoglobaldtors branch August 2, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants