workflows/release-binaries: Enable flang builds on Windows #101344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was fixed in 73d862e.
|
@llvm/pr-subscribers-clang @llvm/pr-subscribers-github-workflow Author: Tom Stellard (tstellar) ChangesThis was fixed in 73d862e. Fixes #100202. Full diff: https://github.com/llvm/llvm-project/pull/101344.diff 1 Files Affected:
diff --git a/.github/workflows/release-binaries.yml b/.github/workflows/release-binaries.yml
index b1b046dbad5f8..2c6f4da8facd2 100644
--- a/.github/workflows/release-binaries.yml
+++ b/.github/workflows/release-binaries.yml
@@ -124,16 +124,8 @@ jobs:
target_cmake_flags="$target_cmake_flags -DBOOTSTRAP_DARWIN_osx_ARCHS=$arches -DBOOTSTRAP_DARWIN_osx_BUILTIN_ARCHS=$arches"
fi
- # x86 macOS and x86 Windows have trouble building flang, so disable it.
- # Windows: https://github.com/llvm/llvm-project/issues/100202
- # macOS: 'rebase opcodes terminated early at offset 1 of 80016' when building __fortran_builtins.mod
build_flang="true"
- if [ "$target" = "Windows-X64" ]; then
- target_cmake_flags="$target_cmake_flags -DLLVM_RELEASE_ENABLE_PROJECTS=\"clang;lld;lldb;clang-tools-extra;bolt;polly;mlir\""
- build_flang="false"
- fi
-
if [ "${{ runner.os }}" = "Windows" ]; then
# The build times out on Windows, so we need to disable LTO.
target_cmake_flags="$target_cmake_flags -DLLVM_RELEASE_ENABLE_LTO=OFF"
|
boomanaiden154
approved these changes
Jul 31, 2024
It looks like flang has a dependecy on compiler-rt. Fixes llvm#100202.
|
It looks like this change also fixed some build failures on macOS too. |
nikic
reviewed
Aug 8, 2024
clang/cmake/caches/Release.cmake
Outdated
| list(APPEND STAGE1_RUNTIMES "compiler-rt") | ||
| if (NOT "compiler-rt" IN_LIST STAGE1_RUNTIMES) | ||
| list(APPEND STAGE1_PROJECTS "compiler-rt") | ||
| endif() |
There was a problem hiding this comment.
It's probably not needed any more. I was planning to conditionally add compiler-rt to stage1 targets based on if flang was enabled or not, but now I think that is too complicated.
|
I'm going to push this tomorrow so it has a chance to land before -rc3. |
|
/cherry-pick 8927576 |
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Aug 29, 2024
Flang for Windows depends on compiler-rt, so we need to enable it for the stage1 builds. This also fixes failures building the flang tests on macOS. Fixes llvm#100202. (cherry picked from commit 8927576)
|
/pull-request #106480 |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/3193 Here is the relevant piece of the build log for the reference |
tru
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Sep 1, 2024
Flang for Windows depends on compiler-rt, so we need to enable it for the stage1 builds. This also fixes failures building the flang tests on macOS. Fixes llvm#100202. (cherry picked from commit 8927576)
tru
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Sep 24, 2024
Flang for Windows depends on compiler-rt, so we need to enable it for the stage1 builds. This also fixes failures building the flang tests on macOS. Fixes llvm#100202. (cherry picked from commit 8927576)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flang for Windows depends on compiler-rt, so we need to enable it for the stage1 builds. This also fixes failures building the flang tests on macOS.
Fixes #100202.