[RISC-V] Use of %0 does not have a corresponding definition on every path with -O0

[patrick-rivos]

Reduced LLVM IR:

define i16 @f() {
BB:
  br label %BB1

BB1:                                              ; preds = %BB1, %BB
  %A = or i16 0, 0
  %B = fcmp true float 0.000000e+00, 0.000000e+00
  %C = or i1 %B, false
  br i1 %C, label %BB1, label %BB2

BB2:                                              ; preds = %BB1
  ret i16 %A
}

Godbolt: https://godbolt.org/z/7GGzqs5c6

BB state before the LiveIntervalAnalysis pass from debug log:

BB.0    BB.3 (unreachable)
 |     /    \
BB.1(loops)  BB.2 -> ret

Since BB.1 defines %0 and BB.2 reads it, LiveIntervalAnalysis complains about
the undefined value in the unreachable codepath.

First visibly bad commit:
af82d01 [RISCV] Separate doLocalPostpass into new pass...

I think this is just because LiveIntervalAnalysis isn't run before this commit.

One step further back is the commit that causes bb to be split into bb.3.
2c18570 [RISCV] Remove setJumpIsExpensive()

Can be mitigated by -mllvm -jump-is-expensive=true

[topperc]

CC @BeMg @lukel97

[lukel97]

On >=O1 those dead blocks are removed before LiveIntervalAnalysis. But I think the correct thing to do here is to teach RISCVInsertVSETVLI to work without LiveIntervals at O0. That way we can keep debug builds fast.

[preames]

Should be fixed by previously referenced commit.

[llvmbot]

@llvm/issue-subscribers-backend-risc-v

Author: Patrick O'Neill (patrick-rivos)

Reduced LLVM IR: ``` define i16 @f() { BB: br label %BB1

BB1: ; preds = %BB1, %BB
%A = or i16 0, 0
%B = fcmp true float 0.000000e+00, 0.000000e+00
%C = or i1 %B, false
br i1 %C, label %BB1, label %BB2

BB2: ; preds = %BB1
ret i16 %A
}

Godbolt: https://godbolt.org/z/7GGzqs5c6

BB state before the LiveIntervalAnalysis pass from debug log:

BB.0 BB.3 (unreachable)
| /
BB.1(loops) BB.2 -> ret

Since BB.1 defines %0 and BB.2 reads it, LiveIntervalAnalysis complains about
the undefined value in the unreachable codepath.

First visibly bad commit:
af82d01fbbce7808605f3a8b22dd1ca7fdec7886 [RISCV] Separate doLocalPostpass into new pass...

I think this is just because LiveIntervalAnalysis isn't run before this commit.

One step further back is the commit that causes bb to be split into bb.3.
2c185709bca195f3d5e062819bba5dd828330548 [RISCV] Remove setJumpIsExpensive()

Can be mitigated by `-mllvm -jump-is-expensive=true`
</details>