[flang] Same condtions appear as operands of LAnd. Copy-pasted code. Maybe the second should be isEqual(x.upper(), y.upper()).

[ustchcs-bugfinder]

llvm-project/flang/lib/Lower/IterationSpace.cpp

Line 451 in 08d094a

isEqual(x.lower(), y.lower()) && isEqual(x.lower(), y.lower());

Current code:

static bool isEqual(const Fortran::evaluate::Substring &x,
                      const Fortran::evaluate::Substring &y) {
    return std::visit(
               [&](const auto &p, const auto &q) { return isEqual(p, q); },
               x.parent(), y.parent()) &&
           isEqual(x.lower(), y.lower()) && isEqual(x.lower(), y.lower()); // ----> Same condition. May be the second should be x.upper()?
  }

[llvmbot]

@llvm/issue-subscribers-flang-ir