cmake: "make install" tries to set permissions on target directories

[llvmbot]

Bugzilla Link	4500
Resolution	FIXED
Resolved on	Feb 10, 2014 05:00
Version	unspecified
OS	Linux
Blocks	llvm/llvm-bugzilla-archive#15732
Reporter	LLVM Bugzilla Contributor
CC	@bradking,@chandlerc,@DougGregor

Extended Description

For me "make install" when using cmake fails with:

Install the project...
-- Install configuration: ""
-- Installing: /usr/local/./include
CMake Error at cmake_install.cmake:36 (FILE):
file Problem setting permissions on directory "/usr/local/./include"

Indeed I don't have permission to change permissions on /usr/local/./include.
And why would I need to? There's no problem installing files inside that
directory, and setting their permissions. I think the fact that cmake is
trying to set permissions on /usr/local/include is a bug.

[llvmbot]

Is this an LLVM bug though, or a cmake bug?

[llvmbot]

I don't know - cmake is an opaque mystery to me. How can I tell?

[llvmbot]

I CCed Doug in the hopes he would know.

[chandlerc]

This seems likely to be this CMake bug:
http://public.kitware.com/Bug/view.php?id=10978

[bradking]

LLVM patch to avoid setting include/ permissions

[bradking]

Clang patch to avoid setting include/ permissions

[bradking]

This is actually a bug in LLVM and Clang's CMake code and not in CMake. The install(DIRECTORY) command documents how it sets permissions on directories, and it is consistent with the behavior observed here. We should not ask CMake to install the top-level "include/" directory for us because it is not exclusive to LLVM or Clang. Instead we should ask it only to handle the "include/llvm", "include/llvm-c", "include/clang", and "include/clang-c" subdirectories.

I've just attached a patch to LLVM and another to Clang to fix this issue.

[chandlerc]

This is actually a bug in LLVM and Clang's CMake code and not in CMake. The
install(DIRECTORY) command documents how it sets permissions on directories,
and it is consistent with the behavior observed here. We should not ask
CMake to install the top-level "include/" directory for us because it is not
exclusive to LLVM or Clang. Instead we should ask it only to handle the
"include/llvm", "include/llvm-c", "include/clang", and "include/clang-c"
subdirectories.

I've just attached a patch to LLVM and another to Clang to fix this issue.

Can you post it to the commit list for review? (Or use Phabricator to do so?)

Thanks for tracking down the root cause of this issue.

[bradking]

Can you post it to the commit list for review?

http://thread.gmane.org/gmane.comp.compilers.llvm.cvs/173963

[llvmbot]

I had been missing this PR for long time, ... :(

Fixed in r201075 and r201076.

I have confirmed Brad fixed this issue with prerequisites:

• root owns PREFIX.
• subdirectories, bin, include, lib, and share are owned by root but writable to installer. (in this case, me)