Skip to content

Backport compiler-extension patches #45162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
serge-sans-paille opened this issue May 6, 2020 · 9 comments
Closed

Backport compiler-extension patches #45162

serge-sans-paille opened this issue May 6, 2020 · 9 comments
Labels
bugzilla Issues migrated from bugzilla

Comments

@serge-sans-paille
Copy link
Collaborator

Bugzilla Link 45817
Resolution FIXED
Resolved on Jun 17, 2020 17:50
Version unspecified
OS Linux
Blocks #44654
CC @tstellar
Fixed by commit(s) d21664c 87dac7d 3a0f6e6 f44a508 8f766e3 e307eeb e849e7a 37309fb 8ceee08 f149195 7831c48 4b932da 0c05269 5f510e5 2f6b23d 576559e 3ca8b23 6f71678

Extended Description

The following patches are related to compiler-extension improvements and should probably be backported to 10.0.1.

8ceee08
37309fb
e849e7a
e307eeb
8f766e3
f44a508

They fix #44215

@tstellar
Copy link
Collaborator

tstellar commented May 7, 2020

It looks like these changes depend on:

https://reviews.llvm.org/rG87dac7da68ea1e0adac78c59ef1891dcf9632b67

Should we backport this one too?

@serge-sans-paille
Copy link
Collaborator Author

yes

@tstellar
Copy link
Collaborator

tstellar commented May 7, 2020

Should we try to backport this one too:

https://reviews.llvm.org/rG3a0f6e699bb6d96dc62dce6faef20ac26cf103fd

@serge-sans-paille
Copy link
Collaborator Author

Holy sh*t, I though this ne was in too. Yes, please.

@serge-sans-paille
Copy link
Collaborator Author

@tstellar
Copy link
Collaborator

tstellar commented May 7, 2020

@serge-sans-paille
Copy link
Collaborator Author

+1

@tstellar
Copy link
Collaborator

Here is a pull request with everything backported: tstellar#155

@tstellar
Copy link
Collaborator

Merged: 6f71678

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
shiltian pushed a commit to shiltian/llvm-project that referenced this issue Dec 15, 2021
…Decl

We would assign the incorrect DeclContext when transforming the RequiresExprBodyDecl, causing incorrect
handling of 'this' inside RequiresExprBodyDecls (bug llvm#45162).

Assign the current context as the DeclContext of the transformed decl.

(cherry picked from commit 9769e1e)
shiltian pushed a commit to shiltian/llvm-project that referenced this issue Dec 15, 2021
…Decl

We would assign the incorrect DeclContext when transforming the RequiresExprBodyDecl, causing incorrect
handling of 'this' inside RequiresExprBodyDecls (bug llvm#45162).

Assign the current context as the DeclContext of the transformed decl.

(cherry picked from commit 9769e1e)
trevor-m pushed a commit to trevor-m/llvm-project that referenced this issue Apr 20, 2023
…Decl

We would assign the incorrect DeclContext when transforming the RequiresExprBodyDecl, causing incorrect
handling of 'this' inside RequiresExprBodyDecls (bug llvm#45162).

Assign the current context as the DeclContext of the transformed decl.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla
Projects
None yet
Development

No branches or pull requests

2 participants