Skip to content

[Attributor] Make use of analysis in the MustBeExecutedExplorer #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jdoerfert opened this issue Mar 13, 2020 · 1 comment
Open

[Attributor] Make use of analysis in the MustBeExecutedExplorer #175

jdoerfert opened this issue Mar 13, 2020 · 1 comment
Labels
good first issue https://github.com/llvm/llvm-project/contribute gsoc Google Summer of Code help wanted Indicates that a maintainer wants help. Not [good first issue].

Comments

@jdoerfert
Copy link
Member

Right now the MustBeExecutedContextExplorer Explorer is created without analysis, e.g., without a dominator tree. As a consequence it is not able to determine non-trivial control flow merge points which reduces the "must-be-executed-context" substantially.

The task is to provide the appropriate analysis getters to the Explorer during creation and update the tests accordingly. If tests for the new capabilities are missing, thus the affected tests do not show the expected effect, new tests need to be added.

@jdoerfert jdoerfert added help wanted Indicates that a maintainer wants help. Not [good first issue]. A-llvm gsoc Google Summer of Code good first issue https://github.com/llvm/llvm-project/contribute labels Mar 13, 2020
@baziotis
Copy link
Contributor

It's great that you made these issues. :) I think it would be good to refer to them somehow from the GSoC projects page.

@asl asl removed the A-llvm label Apr 3, 2020
mem-frob pushed a commit to draperlaboratory/hope-llvm-project that referenced this issue Oct 7, 2022
This commit was made to settle [[ llvm/llvm-project#175 | this issue on GitHub ]].
I added analysis getters for LoopInfo, DominatorTree, and
PostDominatorTree. And I added a test to show an improvement of the
deduction of `dereferenceable` attribute.

Reviewed By: jdoerfert, uenoku

Differential Revision: https://reviews.llvm.org/D76378
vext01 referenced this issue in vext01/llvm-project Jun 28, 2024
Basic floating point lowerings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue https://github.com/llvm/llvm-project/contribute gsoc Google Summer of Code help wanted Indicates that a maintainer wants help. Not [good first issue].
Projects
None yet
Development

No branches or pull requests

3 participants