Skip to content

[libc] add btowc to wchar.h generated header #124152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nickdesaulniers opened this issue Jan 23, 2025 · 4 comments · Fixed by #124168
Closed

[libc] add btowc to wchar.h generated header #124152

nickdesaulniers opened this issue Jan 23, 2025 · 4 comments · Fixed by #124168
Assignees
Labels

Comments

@nickdesaulniers
Copy link
Member

While working on #124150, I noticed that libc/include/wchar.yaml is missing an entry for btowc, even though we have it implemented (libc/src/wchar/btowc.cpp). If we don't advertise it in the generated wchar.h, then users will get a diagnostic when calling it.

@nickdesaulniers nickdesaulniers added good first issue https://github.com/llvm/llvm-project/contribute libc labels Jan 23, 2025
@llvmbot
Copy link
Member

llvmbot commented Jan 23, 2025

@llvm/issue-subscribers-libc

Author: Nick Desaulniers (nickdesaulniers)

While working on #124150, I noticed that libc/include/wchar.yaml is missing an entry for `btowc`, even though we have it implemented (libc/src/wchar/btowc.cpp). If we don't advertise it in the generated wchar.h, then users will get a diagnostic when calling it.

@llvmbot
Copy link
Member

llvmbot commented Jan 23, 2025

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

  1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
  2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
  3. Fix the issue locally.
  4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
  5. Create a Git commit.
  6. Run git clang-format HEAD~1 to format your changes.
  7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

@llvmbot
Copy link
Member

llvmbot commented Jan 23, 2025

@llvm/issue-subscribers-good-first-issue

Author: Nick Desaulniers (nickdesaulniers)

While working on #124150, I noticed that libc/include/wchar.yaml is missing an entry for `btowc`, even though we have it implemented (libc/src/wchar/btowc.cpp). If we don't advertise it in the generated wchar.h, then users will get a diagnostic when calling it.

@alexprabhat99
Copy link
Contributor

Hi @nickdesaulniers
Could you please assign this to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants