Skip to content

Add proper long double is double double support to fpbits #113237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
michaelrj-google opened this issue Oct 22, 2024 · 2 comments
Open

Add proper long double is double double support to fpbits #113237

michaelrj-google opened this issue Oct 22, 2024 · 2 comments
Labels
libc

Comments

@michaelrj-google
Copy link
Contributor

See: #113235

PowerPC uses double double as its long double type. We should add at least basic FPBits support for it. This will be complicated since the fractional part of the float isn't contiguous.
@llvmbot
Copy link
Member

llvmbot commented Oct 22, 2024

@llvm/issue-subscribers-libc

Author: Michael Jones (michaelrj-google)

See: https://github.com//pull/113235

PowerPC uses double double as its long double type. We should add at least basic FPBits support for it. This will be complicated since the fractional part of the float isn't contiguous.

@michaelrj-google michaelrj-google mentioned this issue Oct 22, 2024
Merged
@michaelrj-google
Copy link
Contributor Author

Need to change it to 106, since that's what clang/ppc uses for ldbl mant bits

michaelrj-google added a commit to michaelrj-google/llvm-project that referenced this issue Oct 22, 2024
@michaelrj-google
[libc] Fix long double is double double const
5164c8a 
Turns out for double double LDBL_MANT_DIG == 106. This patch fixes the
constant. Should fix the ppc buildbot.

Previously:
llvm#113235
llvm#113237
llvm#91651
@michaelrj-google michaelrj-google mentioned this issue Oct 22, 2024
Merged
michaelrj-google added a commit that referenced this issue Oct 22, 2024
@michaelrj-google
[libc] Fix long double is double double const (#113258)
4275a73 
Turns out for double double LDBL_MANT_DIG == 106. This patch fixes the
constant. Should fix the ppc buildbot.

Previously:
#113235
#113237
#91651
@h-vetinari h-vetinari mentioned this issue Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
libc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@llvmbot @michaelrj-google