Skip to content

[HLSL] Implement implicit resource binding #110722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tracked by #23 ...
bogner opened this issue Oct 1, 2024 · 1 comment
Open
Tracked by #23 ...

[HLSL] Implement implicit resource binding #110722

bogner opened this issue Oct 1, 2024 · 1 comment
Assignees
Labels
HLSL HLSL Language Support

Comments

@bogner
Copy link
Contributor

bogner commented Oct 1, 2024

Implement implicit binding design as specified in llvm/wg-hlsl#177.

The implicit bindings part of the bindings approach was originally described in #58051, and is a follow up to #110719.

@damyanp
Copy link
Contributor

damyanp commented Oct 7, 2024

We need to find an owner for this who can drive taking it to a design meeting to get this task ready to be worked on.

@davidcook-msft davidcook-msft moved this from Planning to Designing in HLSL Support Oct 15, 2024
@hekota hekota changed the title [HLSL] Calculate implicit resource binding information [HLSL] Implement implicit resource binding Mar 27, 2025
@hekota hekota self-assigned this Apr 2, 2025
bogner added a commit to bogner/llvm-project that referenced this issue Apr 16, 2025
Implicit bindings will cause very confusing crashes in the backend at present,
so this is intended at least partially as a stop gap until we get them
implemented (see llvm#110722).

However, I do think that this is useful in the longer term as well as an
off-by-default warning, as it is quite easy to miss a binding or two when using
explicit bindings and the results of that can be surprisingly hard to debug.
I've filed llvm#135907 to track turning this into an off-by-default warning or
removing it eventually as we see fit.
@bogner bogner marked this as a duplicate of #135745 Apr 16, 2025
bogner added a commit that referenced this issue Apr 16, 2025
Implicit bindings will cause very confusing crashes in the backend at
present, so this is intended at least partially as a stop gap until we
get them implemented (see #110722).

However, I do think that this is useful in the longer term as well as an
off-by-default warning, as it is quite easy to miss a binding or two
when using explicit bindings and the results of that can be surprisingly
hard to debug. I've filed #135907 to track turning this into an
off-by-default warning or removing it eventually as we see fit.
var-const pushed a commit to ldionne/llvm-project that referenced this issue Apr 17, 2025
Implicit bindings will cause very confusing crashes in the backend at
present, so this is intended at least partially as a stop gap until we
get them implemented (see llvm#110722).

However, I do think that this is useful in the longer term as well as an
off-by-default warning, as it is quite easy to miss a binding or two
when using explicit bindings and the results of that can be surprisingly
hard to debug. I've filed llvm#135907 to track turning this into an
off-by-default warning or removing it eventually as we see fit.
@hekota hekota moved this from Designing to Planning in HLSL Support Apr 22, 2025
@hekota hekota moved this from Planning to Designing in HLSL Support Apr 22, 2025
@hekota hekota moved this from Designing to Planning in HLSL Support Apr 23, 2025
@hekota hekota moved this from Planning to Designing in HLSL Support Apr 23, 2025
@hekota hekota moved this from Designing to Active in HLSL Support Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HLSL HLSL Language Support
Projects
Status: Ready
Development

No branches or pull requests

3 participants