Skip to content

llvm/tools/llvm-cgdata/llvm-cgdata.cpp:69: 2 * clumsy string parameter passing #100065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dcb314 opened this issue Jul 23, 2024 · 0 comments · Fixed by #120771
Closed

llvm/tools/llvm-cgdata/llvm-cgdata.cpp:69: 2 * clumsy string parameter passing #100065

dcb314 opened this issue Jul 23, 2024 · 0 comments · Fixed by #120771
Labels
code-quality llvm-tools All llvm tools that do not have corresponding tag

Comments

@dcb314
Copy link

dcb314 commented Jul 23, 2024

Static analyser cppcheck says:

trunk/llvm/tools/llvm-cgdata/llvm-cgdata.cpp:69:39: performance: Function parameter 'Hint' should be passed by const reference. [passedByValue]
trunk/llvm/tools/llvm-cgdata/llvm-cgdata.cpp:68:54: performance: Function parameter 'Whence' should be passed by const reference. [passedByValue]

Source code is

static void exitWithError(Twine Message, std::string Whence = "",
std::string Hint = "") {
@EugeneZelenko EugeneZelenko added llvm-tools All llvm tools that do not have corresponding tag and removed llvm:codegen labels Jul 23, 2024
@AmrDeveloper AmrDeveloper mentioned this issue Dec 20, 2024
Merged
AmrDeveloper added a commit that referenced this issue Jan 20, 2025
@AmrDeveloper
[NFC] llvm-cgdata use StringRef in exitWithError to reduce constructi…
9cbd705 
…on (#120771)

Replace `static void exitWithError(Twine Message, std::string Whence =
"", std::string Hint = "")` std::string with StringRef to remove
constructing Strings on every call or passing by value

Fixes: #100065
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality llvm-tools All llvm tools that do not have corresponding tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[NFC] llvm-cgdata use StringRef in exitWithError to reduce construction AmrDeveloper/llvm-project
2 participants
@dcb314 @EugeneZelenko