[flang] fix evaluate::Expr hashing in lowering (#95079)

jeanPerier · web-flow · commit 1754651dd150 · 2024-06-12T09:22:22.000+02:00
Fixes #61610.
diff --git a/flang/include/flang/Lower/Support/Utils.h b/flang/include/flang/Lower/Support/Utils.h
@@ -502,7 +502,7 @@ class IsEqualEvaluateExpr {
     return std::visit(
                [&](const auto &p, const auto &q) { return isEqual(p, q); },
                x.parent(), y.parent()) &&
-           isEqual(x.lower(), y.lower()) && isEqual(x.lower(), y.lower());
+           isEqual(x.lower(), y.lower()) && isEqual(x.upper(), y.upper());
   }
   static bool isEqual(const Fortran::evaluate::StaticDataObject::Pointer &x,
                       const Fortran::evaluate::StaticDataObject::Pointer &y) {

Original file line number	Diff line number	Diff line change
`@@ -502,7 +502,7 @@ class IsEqualEvaluateExpr {`
`502`	`502`	`return std::visit(`
`503`	`503`	`[&](const auto &p, const auto &q) { return isEqual(p, q); },`
`504`	`504`	`x.parent(), y.parent()) &&`
`505`		`- isEqual(x.lower(), y.lower()) && isEqual(x.lower(), y.lower());`
	`505`	`+ isEqual(x.lower(), y.lower()) && isEqual(x.upper(), y.upper());`
`506`	`506`	`}`
`507`	`507`	`static bool isEqual(const Fortran::evaluate::StaticDataObject::Pointer &x,`
`508`	`508`	`const Fortran::evaluate::StaticDataObject::Pointer &y) {`