PR for llvm/llvm-project#64047 #676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: https://reviews.llvm.org/D157630 (cherry picked from commit 2df9ed11c51ebf6d19f7cb22c3794d1bd460ddf8)
…e multiple reductions. When a loop has multiple reductions, each with an intermediate invariant store, the order in which those reductions are processed is not considered. This can result in the invariant stores outside the loop not preserving the original order. This patch sorts VPReductionPHIRecipes by the order in which they have stores in the original loop before running `InnerLoopVectorizer::fixReduction` function, and it helps to maintain the correct order of stores. Fixes llvm/llvm-project#64047 Differential Revision: https://reviews.llvm.org/D157631 (cherry picked from commit ac65fb869977185b44757b94dc5130bd08c6f7e2)
|
@fhahn @david-arm What do you think about merging this PR to the release branch? |
llvmbot
force-pushed
the
llvm-issue64047
branch
from
f03b6f9 to
94b98e1
Compare
|
This issue missed RC4. The next release is 17.0.0-final. We only take on patches that fix crashes, severe miscompiles, or regressions for the next two weeks. Keep that in mind when reviewing this PR. |
|
LGTM. This fixes a serious miscompile from the LoopVectorizer. |
|
@tru this would be good to pick, if possible, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves llvm/llvm-project#64047