Skip to content

PR for llvm/llvm-project#58794 #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2022
Merged

PR for llvm/llvm-project#58794 #218

merged 1 commit into from
Nov 29, 2022

Conversation

llvmbot
Copy link
Member

@llvmbot llvmbot commented Nov 19, 2022

@llvmbot
Copy link
Member Author

llvmbot commented Nov 19, 2022

@web-flow What do you think about merging this PR to the release branch?

@kasperk81
Copy link

@tstellar, any ideas why it is cherry-picking 154e88a? (same in #216 and #217)

@tstellar
Copy link
Contributor

@tstellar, any ideas why it is cherry-picking 154e88a? (same in #216 and #217)

It's because the release/15.x branch for this repo was out of sync the upstream branch when the pull request was created.

@tstellar
Copy link
Contributor

@kasperk81 How critical is this fix? We are trying to be more conservative since 15.0.6 will be the last 15.0.x release.

@kasperk81
Copy link

kasperk81 commented Nov 23, 2022

@tstellar, it is a small fix and low risk (under isEmptyRecord condition and targeting varargs only). without this fix, the compiler crashes. this make it possible for us to move to clang-15. otherwise we will need to wait another year for clang-16..

…e variadic arg

Fix ARMABIInfo::EmitVAAarg crash with empty record type variadic arg

Open issue: llvm/llvm-project#58794

Reviewed By: rjmccall

Differential Revision: https://reviews.llvm.org/D138137

(cherry picked from commit 80f4446)
@tru tru merged commit 088f336 into release/15.x Nov 29, 2022
@tru tru deleted the llvm-issue58794 branch November 29, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clang-15: crash on va_arg (arm)
5 participants