-
Notifications
You must be signed in to change notification settings - Fork 208
Release Lit v3 pre-release docs with blog post #1116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The only file changed in the move is the root `docs.json` file. Instead a `v2.json` file was added.
This copies over and adds the correct permalinks to the selected version content. Currently moving `v2` -> `unversioned`.
Unversioned links will be generated automatically by the generated unversioned pages.
This works by piping all the content through a function that will fix cross links on unversioned pages.
The versioned URL is stripped for unversioned URLs by our tooling. Add a test to confirm this behavior.
- Replaced sync fs with async fs. - Made lightweight YAML parser more robust using regex.
Currently the Lit 3 commit being used is d04a3e30eb3ae3520fb0ac163fb5ddbbf6030620 because lit/lit#3894 fixes building Lit 3. API docs are visible at /docs/api/v3/
This will hopefully avoid the Github Actions failures.
Thank you Augustine! Re-ran generator with no content changes.
Co-authored-by: Augustine Kim <[email protected]>
- Find replace all /v2/ with /v3/ - Replace api shortcode with api-v3 shortcode - linking to v3 api docs
09f025f
to
d5bf37b
Compare
A live preview of this PR will be available at the URL(s) below. https://pr1116-d5bf37b---lit-dev-5ftespv5na-uc.a.run.app/ |
TODO: Hide from search index. |
This makes the page a duplicate of the v2 page. Git for some reason did not include these changes when merging from main.
A user on v2 docs for a certain page should remain on that page when switching to v3 and vice-versa. This change makes it so switching between v2 and v3 will keep you on the same page, but provide the different versions of the page. Tested manually on every single page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor suggestions
* Update tools section for v3 * Better wording for versions tested
Co-authored-by: Augustine Kim <[email protected]>
Co-authored-by: Augustine Kim <[email protected]>
* Lit 3.0 pre-releases blog post * Apply suggestions from code review * Add link to upgrade guide --------- Co-authored-by: Augustine Kim <[email protected]>
Adds the Lit v3 pre-release documentation. Fixes #1109
/docs/v2
to/docs/v3
.{% api
with{% api-v3
which ensures links to API go to v3 api.versionLinks
). Note this system does not support generated API pages.Requirements pages were updated by @augustjk in #1118 - Thank you!
Tested manually & via existing tests.