Skip to content

Release Lit v3 pre-release docs with blog post #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
May 15, 2023
Merged

Conversation

AndrewJakubowicz
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz commented May 12, 2023

Adds the Lit v3 pre-release documentation. Fixes #1109

  1. Copied all the v2 docs to v3.
  2. Then fixed all cross links /docs/v2 to /docs/v3.
  3. Replaced {% api with {% api-v3 which ensures links to API go to v3 api.
  4. Updated the upgrade guide page with Lit 3.0 specific guidance.
  5. Added a pre-release banner.
  6. Made it so that switching between v2 and v3 keeps you on the same page (using manual versionLinks). Note this system does not support generated API pages.

Requirements pages were updated by @augustjk in #1118 - Thank you!

Tested manually & via existing tests.

AndrewJakubowicz and others added 22 commits May 9, 2023 16:56
The only file changed in the move is the root `docs.json` file. Instead
a `v2.json` file was added.
This copies over and adds the correct permalinks to the selected
version content. Currently moving `v2` -> `unversioned`.
Unversioned links will be generated automatically by the generated
unversioned pages.
This works by piping all the content through a function that will
fix cross links on unversioned pages.
The versioned URL is stripped for unversioned URLs by our tooling.

Add a test to confirm this behavior.
 - Replaced sync fs with async fs.
 - Made lightweight YAML parser more robust using regex.
Currently the Lit 3 commit being used is
d04a3e30eb3ae3520fb0ac163fb5ddbbf6030620 because
lit/lit#3894 fixes building Lit 3.

API docs are visible at /docs/api/v3/
This will hopefully avoid the Github Actions failures.
Thank you Augustine! Re-ran generator with no content changes.
Co-authored-by: Augustine Kim <[email protected]>
 - Find replace all /v2/ with /v3/
 - Replace api shortcode with api-v3 shortcode - linking to v3 api docs
@AndrewJakubowicz
Copy link
Contributor Author

TODO: Hide from search index.

Base automatically changed from version-v3-pre to main May 15, 2023 17:43
This makes the page a duplicate of the v2 page. Git for some reason did
not include these changes when merging from main.
@AndrewJakubowicz AndrewJakubowicz changed the title Add Lit v3 docs (undiscovered) Add Lit v3 pre-release docs May 15, 2023
A user on v2 docs for a certain page should remain on that page when
switching to v3 and vice-versa. This change makes it so switching
between v2 and v3 will keep you on the same page, but provide the
different versions of the page.

Tested manually on every single page.
@AndrewJakubowicz AndrewJakubowicz marked this pull request as ready for review May 15, 2023 20:35
Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor suggestions

augustjk and others added 6 commits May 15, 2023 14:05
* Update tools section for v3

* Better wording for versions tested
* Lit 3.0 pre-releases blog post

* Apply suggestions from code review

* Add link to upgrade guide

---------

Co-authored-by: Augustine Kim <[email protected]>
@AndrewJakubowicz AndrewJakubowicz changed the title Add Lit v3 pre-release docs Add Lit v3 pre-release docs with blog post May 15, 2023
@AndrewJakubowicz AndrewJakubowicz changed the title Add Lit v3 pre-release docs with blog post Release Lit v3 pre-release docs with blog post May 15, 2023
@AndrewJakubowicz AndrewJakubowicz merged commit 00ebfa0 into main May 15, 2023
@AndrewJakubowicz AndrewJakubowicz deleted the version-v3-docs branch May 15, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Lit v3 pre-release documentation under docs/v3
3 participants