Skip to content

Add labs/context package to generated API docs #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from

Conversation

AndrewJakubowicz
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz commented May 2, 2023

Recommend reviewing 1 PR at a time. Builds on #1090

This is a WIP - but I've made the PR early to show that it generates.

AndrewJakubowicz and others added 16 commits May 1, 2023 14:56
This required changing the build setup to use our wireit.

From a spot check this will need more work as some debug only symbols
have crept into the documentation.
The cost does not seem worthwhile for fixing this and blocking progress
on Lit.dev support for v3. Instead unblock by manually providing the
transpiled JavaScript for the Mixin sample.
This is due to a breaking change in TypeDoc.

Default `entryPointStrategy` was changed from `expand` to `resolve`.
Fixed by explicitly setting the prior version.
This fixes the source file links.
The most major change that impacts our documentation generation is the
`Comment` node has been updated to be a list of partial text fragments.

We instead used to use a first line `shortText`, and remainder in
`text`.
This commit "fakes" that setup by doing the processing manually.
For example see parameters in:
/docs/api/ReactiveElement/#ReactiveElement.requestUpdate
Tested by checking `observedAttributes` docs and `updateComplete`
@github-actions
Copy link

github-actions bot commented May 2, 2023

A live preview of this PR will be available at the URL(s) below.
The latest URL will be appended to this comment on each push.
Each build takes ~5-10 minutes, and will 404 until finished.

https://pr1092-ec9e4af---lit-dev-5ftespv5na-uc.a.run.app/

@AndrewJakubowicz AndrewJakubowicz changed the base branch from main to update-docs-typedoc May 2, 2023 22:29
@justinfagnani
Copy link
Contributor

The API docs are weird here. It seems to be documenting every class/interface member as a top-level module export.

@AndrewJakubowicz
Copy link
Contributor Author

Oh yeah that is weird. I'm currently working on updating TypeDoc yet again to the most recent version to try and fix some of this weirdness.

Base automatically changed from update-docs-typedoc to main May 3, 2023 18:12
@AndrewJakubowicz
Copy link
Contributor Author

Figured it out - but was easier to start fresh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants