-
Notifications
You must be signed in to change notification settings - Fork 409
rustfmt
: Reformat the fuzz
dir
#3102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3102 +/- ##
==========================================
+ Coverage 89.80% 89.82% +0.02%
==========================================
Files 119 119
Lines 98070 98070
Branches 98070 98070
==========================================
+ Hits 88068 88094 +26
+ Misses 7421 7399 -22
+ Partials 2581 2577 -4 ☔ View full report in Codecov by Sentry. |
f329436
to
ad91338
Compare
Should be good for initial reviews. |
8967fc6
to
6b40382
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to go ahead and land all the "simple" stuff (ie everything but full_stack and chanmon_consistency) here and do the rest in a separate PR?
6b40382
to
4df1953
Compare
Now split them out to #3111 and rebased this on top. |
90962df
to
f0a01dd
Compare
Ugh, I forgot I also had #3113 lying around locally that was waiting on a now-merged PR... |
If that's alright. Its more annoying to rebase that than |
SGTM |
677eda5
to
0466ef0
Compare
0466ef0
to
b0fc556
Compare
Rebased and addressed comments after #3113 landed. |
b7e1662
to
3aff728
Compare
3aff728
to
027e9a5
Compare
e8d5b76
to
27216d0
Compare
Force-pushed with this fixup: > git diff-tree -U2 027e9a576 4e9ce52c7
diff --git a/fuzz/src/chanmon_consistency.rs b/fuzz/src/chanmon_consistency.rs
index 66ff157e7..c4d179e74 100644
--- a/fuzz/src/chanmon_consistency.rs
+++ b/fuzz/src/chanmon_consistency.rs
@@ -589,5 +589,14 @@ fn send_hop_noret(
amt: u64, payment_id: &mut u8, payment_idx: &mut u64,
) {
- send_payment(source, dest, dest_chan_id, amt, payment_id, payment_idx);
+ send_hop_payment(
+ source,
+ middle,
+ middle_chan_id,
+ dest,
+ dest_chan_id,
+ amt,
+ payment_id,
+ payment_idx,
+ );
} |
27216d0
to
4e9ce52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff from @valentinewallace's ACK is small and its all fuzz code anyway, so not bothering to wait for her to look again.
We run
rustfmt
on thefuzz
dir and make sure that any auto-generated targets are formatted, too.