Skip to content

Move Payment Retrying into ChannelManager #1932

Closed
@TheBlueMatt

Description

@TheBlueMatt

We've started down the path, now we need to land it (ideally all in one release so our API isn't randomly weird).

  • Address follow-up from ChannelManager Payment Retries #1916
  • Deduplicate PendingTLCsForwardable events, see ChannelManager Payment Retries #1916 (comment)
  • Support automatic retry methods for spontaneous payments
  • Move payment path scoring to BackgroundProcessor
    • Remove scoring methods from Router trait
  • Replace the InvoicePayer with invoice paying utility methods
  • Remove support for manual retries in ChannelManager + take abandon_payment private and call it on the user's behalf
  • Simplify send_payment_with_retry return value: don't include the PartialFailure variant, and instead generate PaymentPathFailed events for the failed paths on partial failure
  • Migrate ScorerAccountingForInFlightHtlcs tests from InvoicePayer: considers_inflight_htlcs_between_retries
  • Remove retry field from PaymentPathFailed

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions