-
Notifications
You must be signed in to change notification settings - Fork 899
Update Dependencies #1509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dependencies #1509
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,10 +34,14 @@ | |
|
||
<ItemGroup> | ||
<PackageReference Include="LibGit2Sharp.NativeBinaries" Version="[1.0.185]" PrivateAssets="contentFiles" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should go ahead and build a new native binaries package that we can update to as well. 1.0.185 doesn't have all of the changes I made around support netstandard. |
||
<PackageReference Include="SourceLink.Create.GitHub" Version="2.2.0" PrivateAssets="all" /> | ||
<PackageReference Include="SourceLink.Create.GitHub" Version="2.5.0" PrivateAssets="all" /> | ||
<DotNetCliToolReference Include="dotnet-sourcelink-git" Version="2.2.0" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The DotNetCliToolReference also needs to be bumped to 2.5.0. |
||
</ItemGroup> | ||
|
||
<ItemGroup> | ||
<PackageReference Update="Nerdbank.GitVersioning" Version="2.0.41" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above. This is already in the Directory.Build.props file. I'd say there's an argument that we don't need it there, since this is the only project that actually cares about the version, and having it in the props file means it applies to the test project as well. If we do keep it here instead, the extra ItemGroup should be removed and it should go up with the other packages above. It also needs |
||
</ItemGroup> | ||
|
||
<Import Project="CodeGenerator.targets" /> | ||
|
||
<Target Name="SetNuSpecProperties" BeforeTargets="GenerateNuspec" DependsOnTargets="GetBuildVersion"> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is currently in the Directory.Build.props file, so we should either update that one entry, or remove it if we want it in the project files after all.