Package improvements #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's needed when building libgit2, and it's useful to have in the package.
|
👍 |
alex-weaver
pushed a commit
to alex-weaver/libgit2sharp.nativebinaries
that referenced
this pull request
Mar 23, 2023
Package improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the following changes:
The props file now includes files with
ContentWithTargetPathinstead ofNonewhich means the files will still get copied where they need to go, but they won't show up as items in Solution Explorer.Instead of adding libgit2_hash.txt and libgit2_filename.txt to assemblies as embedded resources, those values are now added as MSBuild properties. I'll then be able to use those in the relevant target files in LibGit2Sharp.
There are now two props files, one for net461 and greater, which has all of the file copying stuff in it as usual, and one that will be referenced when using anything other than .NET Framework TFMs. That one only has the new MSBuild properties in it. This is primarily here so LibGit2Sharp has access to it since it will be netstandard2.0 only soon. We don't need any of file copy stuff there.
@ethomson Any objections to me merging this and then getting a new package up on nuget.org?