CI: test building libbpf-rs with libbpf-sys #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libbpf-sys aims to adhere to semantic versioning rules and indicate incompatible changes by bumping major version numbers. However, it is sometimes hard to identify breaking changes in advance and so breakage may happen unintentionally. Detecting of such breaking changes also becomes harder with auto-generated code, and libbpf-sys has a bunch of that, owing due to it binding to a C library. For example, in libbpf-rs [0] we have encountered a case where we were relying on a bindgen generated type exported by libbpf-sys that got removed because bindgen changed its behavior, which effectively is a semver violation. To aid with the detection such unintended incompatibilities, this change adds a CI step that builds the most recent published version of libbpf-rs with the current libbpf-sys snapshot, to flag accidental breakage. [0] libbpf/libbpf-rs#303 Closes: libbpf#53 Signed-off-by: Daniel Müller <[email protected]>
|
Here is a test run with a problem similar to what we saw earlier with |
|
Apologies for the late follow-up. This looks great. I'm going to merge this and then go a bit further by making it a prerequisite for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libbpf-sys aims to adhere to semantic versioning rules and indicate incompatible changes by bumping major version numbers. However, it is sometimes hard to identify breaking changes in advance and so breakage may happen unintentionally. Detecting of such breaking changes also becomes harder with auto-generated code, and libbpf-sys has a bunch of that, owing due to it binding to a C library. For example, in libbpf-rs [0] we have encountered a case where we were relying on a bindgen generated type exported by libbpf-sys that got removed because bindgen changed its behavior, which effectively resulted in a semver violation.
To aid with the detection such unintended incompatibilities, this change adds a CI step that builds the most recent published version of libbpf-rs with the current libbpf-sys snapshot, to flag accidental breakage.
[0] libbpf/libbpf-rs#303
Closes: #53
Signed-off-by: Daniel Müller [email protected]