Skip to content

chore: Update implementation and move to github actions. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

kinyoklion
Copy link
Member

No description provided.

@kinyoklion kinyoklion marked this pull request as ready for review December 6, 2024 18:34
@kinyoklion kinyoklion requested a review from keelerm84 December 6, 2024 18:35
@kinyoklion kinyoklion enabled auto-merge (squash) December 6, 2024 18:35
Comment on lines +30 to +33
if (!sdkKey) {
console.log('*** Please edit index.js to set sdkKey to your LaunchDarkly SDK key first.');
process.exit(1);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have this, should we not default the SDK variable above to "your-sdk-key"?

@kinyoklion kinyoklion merged commit c65a760 into main Dec 6, 2024
1 check passed
@kinyoklion kinyoklion deleted the rlamb/ide-668/migrate-github-actions branch December 6, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants