fix Builder.php - not actually using returned results from afterRawSearchCallback #919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix using afterRawSearchCallback without actually getting back the returned results. If the purpose of the afterRawSearchCallback is to allow changes to be made on preprocessed raw results then this part was probably left out by mistake.
gdebrauwer
reviewed
Mar 27, 2025
use original results if afterRawSearchCallback doesn't return anything Co-authored-by: Günther Debrauwer <[email protected]>
|
@gdebrauwer thank you for the catch, you're definitely right, applied and committed your suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix using afterRawSearchCallback without actually getting back the returned results.
If the purpose of the afterRawSearchCallback is to allow changes to be made on preprocessed raw results then this part was probably left out by mistake.
I believe this was the intended use for this callback that was unintentionally missed.